Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable mocha-clean in egg-bin test #1010

Closed
fengmk2 opened this issue Jun 7, 2017 · 10 comments · Fixed by eggjs/egg-bin#59
Closed

enable mocha-clean in egg-bin test #1010

fengmk2 opened this issue Jun 7, 2017 · 10 comments · Fixed by eggjs/egg-bin#59

Comments

@fengmk2
Copy link
Member

fengmk2 commented Jun 7, 2017

mocha-clean : Cleans up mocha test stack traces.

cc @huacnlee

@atian25
Copy link
Member

atian25 commented Jun 7, 2017

interesting~

@atian25
Copy link
Member

atian25 commented Jun 7, 2017

研究了下,不能直接用它,浏览器方面的支持我们不需要,还有它对 npminstall 的判断不支持,可以自己在 egg-bin test 里面处理下,我搞搞。

@okoala
Copy link
Member

okoala commented Jun 7, 2017

如果格式化的话,就无法做到通过点击链接打开文件了吧~

@atian25
Copy link
Member

atian25 commented Jun 7, 2017

可以的,本来输出就是不带绝对路径的,转换后,我们反而可以变为绝对路径。但相对路径应该就够了。

@huacnlee
Copy link
Contributor

huacnlee commented Jun 7, 2017

@okoala 打开文件是少数情况,看到常常的日志是多数情况,其实复制一下就可以了

@atian25
Copy link
Member

atian25 commented Jun 8, 2017

landed at 3.5.0

其实 mocha 内部已经有这段逻辑了, https://github.com/mochajs/mocha/blob/master/lib/utils.js#L738

只是它过滤的不够,还有对我们的 tnpm 的安装格式支持不好。

@atian25
Copy link
Member

atian25 commented Jun 8, 2017

image

@okoala 可以点击的。

@okoala
Copy link
Member

okoala commented Jun 8, 2017

👍

@fengmk2
Copy link
Member Author

fengmk2 commented Jun 8, 2017

点击是怎样做到的?

@atian25
Copy link
Member

atian25 commented Jun 8, 2017

oh-my-zsh 下按下 CMD 键,鼠标悬浮链接上就可以了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants