Skip to content

feat: revert egg-bin check #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .autod.conf
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ module.exports = {
'intelli-espower-loader',
'power-assert',
'ypkgfiles',
'eslint-plugin-eggache',
'eslint',
],
devdep: [
'autod',
Expand Down
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
node_modules/
coverage/
test/fixtures/enzyme-example-mocha/
test/fixtures/check-eggache/
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,16 +192,6 @@ Generate `pkg.dependencies` and `pkg.devDependencies` automatically, see [autod]
$ egg-bin autod
```

## check

Check egg project for collect useful infomation to report issue.

```bash
$ egg-bin check
```
### Rules:
- [eslint-plugin-eggache](https://github.com/eggjs/eslint-plugin-eggache)

## Custom egg-bin for your team

You maybe need a custom egg-bin to implement more custom features if your team has develop a framework base on egg.
Expand Down
6 changes: 0 additions & 6 deletions lib/check-eslintrc

This file was deleted.

41 changes: 0 additions & 41 deletions lib/cmd/check.js

This file was deleted.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
"debug": "^3.1.0",
"detect-port": "^1.2.2",
"egg-utils": "^2.3.0",
"eslint": "^4.18.1",
"eslint-plugin-eggache": "^1.0.0",
"globby": "^8.0.1",
"inspector-proxy": "^1.2.1",
"intelli-espower-loader": "^1.0.1",
Expand Down
9 changes: 0 additions & 9 deletions test/fixtures/check-eggache/config/config.default.js

This file was deleted.

7 changes: 0 additions & 7 deletions test/fixtures/check-eggache/config/plugin.js

This file was deleted.

7 changes: 0 additions & 7 deletions test/fixtures/check-eggache/other.js

This file was deleted.

3 changes: 0 additions & 3 deletions test/fixtures/check-eggache/package.json

This file was deleted.

4 changes: 2 additions & 2 deletions test/lib/cmd/autod.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ describe('test/lib/cmd/autod.test.js', () => {
it('should autod check fail', function* () {
const cwd = path.join(__dirname, '../../fixtures/autod-missing');
yield coffee.fork(eggBin, [ 'autod', '--check' ], { cwd })
// .debug()
.debug()
.expect('code', 1)
.expect('stderr', /\[ERROR\] Missing dependencies: \["urllib"\]/)
.expect('stderr', /\[ERROR\].*Missing dependencies: \["urllib"\]/)
.end();
});

Expand Down
32 changes: 0 additions & 32 deletions test/lib/cmd/check.test.js

This file was deleted.

2 changes: 2 additions & 0 deletions test/lib/cmd/cov.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@ const path = require('path');
const assert = require('assert');
const coffee = require('coffee');
const mm = require('mm');
const rimraf = require('mz-modules/rimraf');

describe('test/lib/cmd/cov.test.js', () => {
const eggBin = require.resolve('../../../bin/egg-bin.js');
const cwd = path.join(__dirname, '../../fixtures/test-files');

beforeEach(() => rimraf(path.join(cwd, 'coverage')));
afterEach(mm.restore);

it('should success', done => {
Expand Down