Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dark and light theme flavors #40

Open
egel opened this issue Sep 22, 2024 · 2 comments
Open

feat: add dark and light theme flavors #40

egel opened this issue Sep 22, 2024 · 2 comments
Labels
documentation An issue that needs or change the documentation of the project enhancement feedback wanted

Comments

@egel
Copy link
Owner

egel commented Sep 22, 2024

Add dark and light theme flavors?

  • hard
  • medium
  • soft
@egel egel added enhancement documentation An issue that needs or change the documentation of the project labels Sep 22, 2024
@egel egel changed the title feat: add light theme flavors feat: add dark and light theme flavors Sep 22, 2024
@egel
Copy link
Owner Author

egel commented Sep 22, 2024

After writing this issue, I am still wondering if these flavors make sense in the tmux theme...

The reasoning that remains in my mind is as follows. Suppose we look at an editor, for example, someone who is using Vim with also a gruvbox theme with "hard" flavor. Then the Vim editor has indeed different backgrounds (that are defined by flavors), and also many more elements that require different colors. Although the color of the bottom action bar remains the same.

In our case (in tmux), we have one small bar, which in the case of the schematic picture above, should remain with the same color. Maintaining this momentum, the tmux theme also remains uniform regardless of the differences in the flavor used. I am biased, and maybe need a bit more time until this will clear in my head.

I am curious what do you think about that?

@egel
Copy link
Owner Author

egel commented Sep 28, 2024

One additional portion I noticed that could be useful for the users is to differentiate/emphasize the colors from the surroundings.

Here is a comment where the colors are not visually standing out. #21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue that needs or change the documentation of the project enhancement feedback wanted
Projects
None yet
Development

No branches or pull requests

1 participant