Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: use USERPROFILE instead of HOME variable #25

Closed
johnd0e opened this issue Oct 20, 2024 · 5 comments
Closed

Windows: use USERPROFILE instead of HOME variable #25

johnd0e opened this issue Oct 20, 2024 · 5 comments

Comments

@johnd0e
Copy link

johnd0e commented Oct 20, 2024

No description provided.

@efugier
Copy link
Owner

efugier commented Oct 21, 2024

Hey, I never worked on windows machines so my knowledge about the issue is a bit limited.

Can you tell me what you think would be the ideal behavior:

  1. Check $HOME then $USERPROFILE if there's no $HOME
  2. Check $USERPROFILE only on windows and $HOME on everything else

That said, you currently can have the config live anywhere as per the README:

smartcat/README.md

Lines 216 to 217 in 5469956

- by default lives at `$HOME/.config/smartcat`
- the directory can be set using the `SMARTCAT_CONFIG_PATH` environement variable

@johnd0e
Copy link
Author

johnd0e commented Oct 21, 2024

I think 2 is better.

@efugier
Copy link
Owner

efugier commented Oct 21, 2024

Done in 1.6.0!

@efugier efugier closed this as completed Oct 21, 2024
@johnd0e
Copy link
Author

johnd0e commented Oct 21, 2024

Worth to mention that there are other related variables on Linix/Macos too: sigoden/aichat#889

@efugier
Copy link
Owner

efugier commented Oct 21, 2024

Thanks for pointing it out but one default by OS will be where I draw the line.

If people want to have a custom directory there still is the SMARTCAT_CONFIG_PATH env variable that can be set to anything they want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants