Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need more LIBCUCKOO_SQUELCH_PADDING_WARNING #131

Open
grandinj opened this issue Jan 25, 2021 · 1 comment
Open

need more LIBCUCKOO_SQUELCH_PADDING_WARNING #131

grandinj opened this issue Jan 25, 2021 · 1 comment

Comments

@grandinj
Copy link

hi

thanks for this awesome project!

with latest MSVC, warnings have moved around, and we need an extra warning suppress, like this:

bool &is_migrated() noexcept { return is_migrated_; }
bool is_migrated() const noexcept { return is_migrated_; }

private:
std::atomic_flag lock_;
counter_type elem_counter_;
bool is_migrated_;
LIBCUCKOO_SQUELCH_PADDING_WARNING
};

@manugoyal
Copy link
Contributor

Hi Noel, thanks for reporting! I don't have MSVC myself, so I can't verify too easily. But I would be happy to accept a pull request that suppresses these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants