Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please get rid of SuperFastHash #13

Open
dave-andersen opened this issue Dec 16, 2016 · 0 comments
Open

Please get rid of SuperFastHash #13

dave-andersen opened this issue Dec 16, 2016 · 0 comments

Comments

@dave-andersen
Copy link
Member

First, the license on the external superfasthash code I can find isn't GPL, it's a BSD-ish one. But if we're not using it, I'd rather not have it in there, and even hinting that there's GPLed code in the file is twitchy. I suggest that we rip out the compiled hashutil file and separate the original hash functions from other people into their constituent parts, each preserving their own original license unless we reimplement them on our own. I'm happy to do this if we want.

Alternately, we can just rip out everything except our own and TwoIndependentMultiplyShift. I think I'd rather do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant