Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no difference under embroider? (or I missed something!) #6

Closed
NullVoxPopuli opened this issue Nov 24, 2023 · 2 comments
Closed

no difference under embroider? (or I missed something!) #6

NullVoxPopuli opened this issue Nov 24, 2023 · 2 comments

Comments

@NullVoxPopuli
Copy link

Trying things out here: NullVoxPopuli/package-majors#3 (comment)

This is a very small app (one route, < 10 components). but I'd expect at least byte-count changes with my handfull of decorators
image
@NullVoxPopuli
Copy link
Author

oh nevermind, I need to wait for embroider-build/embroider#1673 to be released

@NullVoxPopuli NullVoxPopuli mentioned this issue Nov 24, 2023
Merged
@NullVoxPopuli
Copy link
Author

fixed!

using the decorator-transforms on a tiny embroider app, It looks like I've lost about 44KB -- or about 9.4% of the total size.

This is impressive, because I'm barely using any decorators at all in this app. Just goes to show how impactful / devestating the property transforms are.

before/after proof here: NullVoxPopuli/package-majors#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NullVoxPopuli