Skip to content

Commit a579f30

Browse files
authored
Upgrade dependencies + minor fixes (#19)
* Upgrade minimum datadog version + minor fixes * explicitly declare dep on setuptools and fix shebang
1 parent 6bfec55 commit a579f30

File tree

5 files changed

+17
-14
lines changed

5 files changed

+17
-14
lines changed

README.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ Example Graphs
8787
```
8888
git clone [email protected]:eero-inc/garbagedog.git
8989
cd garbagedog
90-
virtualenv --python=python3 ENV
90+
python3 -m venv ENV
9191
source ENV/bin/activate
9292
pip install -e .
9393
```
@@ -97,7 +97,7 @@ pip install -e .
9797
```
9898
git clone [email protected]:eero-inc/garbagedog.git
9999
cd garbagedog
100-
virtualenv --python=python3 ENV
100+
python3 -m venv ENV
101101
source ENV/bin/activate
102102
pip install -r dev_requirements.txt
103103
@@ -110,12 +110,13 @@ On your targeted environment check out the source and build
110110
```
111111
git clone [email protected]:eero-inc/garbagedog.git
112112
cd garbagedog
113-
virtualenv --python=python3 ENV
113+
python3 -m venv ENV
114114
source ENV/bin/activate
115115
pip install pex
116116
./build.sh
117117
```
118118

119119
## About
120120
Made for [eero](https://eero.com/) Hack Week 2017 - ps we're hiring! https://eero.com/jobs
121+
121122
Not related to the retired RedHat project also called garbagedog

build.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ if [[ "$OSTYPE" == "darwin"* ]]; then
99
fi
1010

1111
ARTIFACT=./dist/garbagedog-${OS}-${VERSION}.pex
12-
env PEX_VERBOSE=1 pex . -r requirements.txt -o ${ARTIFACT} -c garbagedog --disable-cache -f $PWD && echo Built to ${ARTIFACT}
12+
env PEX_VERBOSE=1 pex . -r requirements.txt -o ${ARTIFACT} -c garbagedog --python-shebang="/usr/bin/env python3" --disable-cache -f $PWD && echo Built to ${ARTIFACT}

dev_requirements.txt

+1
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ mock
22
mypy
33
pycodestyle
44
pytest
5+
pex

garbagedog/constants.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@
55

66
# These regexes are modified from https://github.com/Netflix-Skunkworks/gcviz, Copyright 2013 Netflix, under APACHE 2.0
77
THREE_ARROWS_REGEX = re.compile("->.*->.*->", re.MULTILINE)
8-
SIZE_REGEX = re.compile("^([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[.][0-9]{3}[+]0000):"
9-
" ([0-9]+[.][0-9]{3}): .* ([0-9]+)K->([0-9]+)K\(([0-9]+)K\).*"
10-
" ([0-9]+)K->([0-9]+)K\(([0-9]+)K\)", re.MULTILINE)
8+
SIZE_REGEX = re.compile(r"^([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[.][0-9]{3}[+]0000):"
9+
r" ([0-9]+[.][0-9]{3}): .* ([0-9]+)K->([0-9]+)K\(([0-9]+)K\).*"
10+
r" ([0-9]+)K->([0-9]+)K\(([0-9]+)K\)", re.MULTILINE)
1111

12-
ABSOLUTE_TIME_REGEX = re.compile("^([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[.][0-9]{3}[+]0000):", re.MULTILINE)
13-
RELATIVE_TIME_REGEX = re.compile("^[0-9]+[.][0-9]+: ")
12+
ABSOLUTE_TIME_REGEX = re.compile(r"^([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[.][0-9]{3}[+]0000):", re.MULTILINE)
13+
RELATIVE_TIME_REGEX = re.compile(r"^[0-9]+[.][0-9]+: ")
1414

15-
CONFLATED_RELATIVE_REGEX = re.compile("(^.*[0-9]+[.][0-9]+ secs])([0-9]+[.][0-9]+: .*$)", re.MULTILINE)
16-
CONFLATED_ABSOLUTE_REGEX = re.compile("(^.*)([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.*)", re.MULTILINE)
15+
CONFLATED_RELATIVE_REGEX = re.compile(r"(^.*[0-9]+[.][0-9]+ secs])([0-9]+[.][0-9]+: .*$)", re.MULTILINE)
16+
CONFLATED_ABSOLUTE_REGEX = re.compile(r"(^.*)([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.*)", re.MULTILINE)
1717

18-
TIMES_REGEX = re.compile(".*real=([0-9][0-9]*[.][0-9][0-9]*) secs\]\s*", re.MULTILINE)
18+
TIMES_REGEX = re.compile(r".*real=([0-9][0-9]*[.][0-9][0-9]*) secs\]\s*", re.MULTILINE)
1919

2020
TIMEFORMAT = "%Y-%m-%dT%H:%M:%S.%f%z"
2121

setup.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
setup(
44
name='garbagedog',
5-
version='0.0.12',
5+
version='0.0.14',
66
description='Parse JVM gc.logs and emit stats over dogstatsd',
77
author='Will Bertelsen',
88
author_email='[email protected]',
@@ -14,7 +14,8 @@
1414
],
1515
python_requires='>=3.4',
1616
install_requires=[
17-
'datadog',
17+
'datadog>=0.26.0',
1818
'typing',
19+
'setuptools>=40.8.0'
1920
],
2021
)

0 commit comments

Comments
 (0)