Merge pull request #1769 from edx/katebygrace/remove-securescm

chore: remove secure scm

Author: HassanJaveed84

dataeng/jobs/analytics/SnowflakeCollectMetrics.groovy

@@ -2,8 +2,6 @@ package analytics
 
 import static org.edx.jenkins.dsl.AnalyticsConstants.common_log_rotator
 import static org.edx.jenkins.dsl.AnalyticsConstants.common_publishers
-import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm
-import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm_parameters
 
 
 class SnowflakeCollectMetrics {
@@ -23,7 +21,6 @@ class SnowflakeCollectMetrics {
             dslFactory.job(jobConfig['NAME']){
 
                 logRotator common_log_rotator(allVars)
-                parameters secure_scm_parameters(allVars)
                 parameters {
                     stringParam('ANALYTICS_TOOLS_URL', allVars.get('ANALYTICS_TOOLS_URL'), 'URL for the analytics tools repo.')
                     stringParam('ANALYTICS_TOOLS_BRANCH', allVars.get('ANALYTICS_TOOLS_BRANCH'), , 'Branch of analytics tools repo to use.')
@@ -36,7 +33,7 @@ class SnowflakeCollectMetrics {
                     env('SNOWFLAKE_WAREHOUSE', 'LOADING')
                     env('METRIC_NAME', jobConfig['NAME'])
                 }
-                multiscm secure_scm(allVars) << {
+                multiscm {
                     git {
                         remote {
                             url('$ANALYTICS_TOOLS_URL')

dataeng/jobs/analytics/SnowflakePublicGrantsCleaner.groovy

@@ -6,16 +6,13 @@ import static org.edx.jenkins.dsl.AnalyticsConstants.common_log_rotator
 import static org.edx.jenkins.dsl.AnalyticsConstants.common_wrappers
 import static org.edx.jenkins.dsl.AnalyticsConstants.common_publishers
 import static org.edx.jenkins.dsl.AnalyticsConstants.common_triggers
-import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm_parameters
-import static org.edx.jenkins.dsl.AnalyticsConstants.secure_scm
 
 
 
 class SnowflakePublicGrantsCleaner {
     public static def job = { dslFactory, allVars ->
         dslFactory.job("snowflake-public-grants-cleaner") {
             logRotator common_log_rotator(allVars)
-            parameters secure_scm_parameters(allVars)
             parameters {
                 stringParam('ANALYTICS_TOOLS_URL', allVars.get('ANALYTICS_TOOLS_URL'), 'URL for the analytics tools repo.')
                 stringParam('ANALYTICS_TOOLS_BRANCH', allVars.get('ANALYTICS_TOOLS_BRANCH'), 'Branch of analtyics tools repo to use.')
@@ -28,7 +25,7 @@ class SnowflakePublicGrantsCleaner {
                 env('USER', allVars.get('USER'))
                 env('ACCOUNT', allVars.get('ACCOUNT'))
             }
-            multiscm secure_scm(allVars) << {
+            multiscm {
                 git {
                     remote {
                         url('$ANALYTICS_TOOLS_URL')