Search in multivalue fields - #6
Conversation
99c0ed1 to
dbd93e5
Compare
7e0ff82 to
a712f86
Compare
… to" predicate when searching in multivalue fields
a712f86 to
b5444b2
Compare
There was a problem hiding this comment.
@e-kolpakov Are these lyrics under a compatible license? I know it may seem silly, but it's something we probably need to be sure of.
There was a problem hiding this comment.
@e-kolpakov Nevermind, I see this existed beforehand.
|
@e-kolpakov Aside from that question about the docs, this looks good to me. 👍 |
|
@martynjames you might want to review this (or assign someone else) |
|
Thanks @e-kolpakov - will look at it. Would've been easier if the separating of the tests into different files would have been separated from the actual changes you were implementing. Never mind about that now - but this is one case where having 2 different commits would actually make sense! |
|
👍 - Please next time consider separating the refactoring into a separate PR or at least a separate commit. |
|
@martynjames sure, thank you for review. |
Search in multivalue fields
Description: Documented search behavior of using
containspredicate instead ofequal_toif search value is singular and document value is multivalue one.Background: the only supported search engine so far (elastic) analyses multivalues fields essentially resulting in "contains in" search using
termfilter/query, as opposed to "equals to" when non-multivalue field is used. This behavior considered a good syntax, so it was documented and covered with tests.JIRA ticket: SOL-591
Also, I've took the responsibility of splitting single 1500+ line long test module into smaller modules. There are no changes in moved test suites except necessary modifications to
patchcalls.