Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aurora datadog enable flags #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jansenk
Copy link
Member

@jansenk jansenk commented Jun 11, 2024

Paired with https://github.com/edx/edx-internal/pull/11048


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@jansenk jansenk force-pushed the jkantor/aurora-dd-enable-flags branch from 6a0fe4b to 7ffbc53 Compare June 11, 2024 16:22
@@ -15,7 +15,7 @@
- install:app-requirements

- name: "Install Datadog APM requirements"
when: COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP
when: XQWATCHER_DATADOG_ENABLED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some instances in this file are ENABLED instead of ENABLE.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whew thank you for catching this 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants