diff --git a/Directory.Build.props b/Directory.Build.props index c5e11e54..16cb0241 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -13,6 +13,33 @@ true false + + true diff --git a/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationHostTests.cs b/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationHostTests.cs index e1ac31e7..3b3a8dab 100644 --- a/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationHostTests.cs +++ b/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationHostTests.cs @@ -6,7 +6,7 @@ public class AddTestConfigurationHostTests /// /// Tests that adds two /// to the app configuration. - /// This test serves as a control test because all the tests use the as a way + /// This test serves as a control test because all the tests use the as a way /// to setup a with several and at least two . /// If this changes in the future then I could start having false positives on the other tests. /// diff --git a/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationWebHostTests.cs b/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationWebHostTests.cs index 43ac2463..8e9bdde6 100644 --- a/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationWebHostTests.cs +++ b/tests/DotNet.Sdk.Extensions.Testing.Tests/Configuration/AddTestConfigurationWebHostTests.cs @@ -3,10 +3,24 @@ namespace DotNet.Sdk.Extensions.Testing.Tests.Configuration; [Trait("Category", XUnitCategories.Configuration)] public class AddTestConfigurationWebHostTests { + // On the below summary I'm not using a tag for WebHost.CreateDefaultBuilder() + // because the static WebHost exists on both Microsoft.AspNetCore and Microsoft.AspNetCore.Hosting + // and I have both of then as global usings. + // Now in terms of code there's no clash and need to use full namespaces to disambiguate because + // the Microsoft.AspNetCore.Hosting.WebHost is internal and Microsoft.AspNetCore.WebHost is public, + // so it always picks the public one. + // + // HOWEVER, in code comments you can reference internal types so there's no way to know which one should + // be used without doing . + // The problem occurs when I run dotnet format and it says that I should remove Microsoft.AspNetCore from the + // cref attribute because it sees it on the global usings. + // + // For now I'm working around this problem by NOT using cref for this case. + /// - /// Tests that adds two + /// Tests that WebHost.CreateDefaultBuilder() adds two /// to the app configuration. - /// This test serves as a control test because all the tests use the as a way + /// This test serves as a control test because all the tests use the WebHost.CreateDefaultBuilder() as a way /// to setup a with several and at least two . /// If this changes in the future then I could start having false positives on the other tests. /// diff --git a/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/HttpMessageHandlers/ResponseMocking/HttpResponseMessageMockBuilderTests.cs b/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/HttpMessageHandlers/ResponseMocking/HttpResponseMessageMockBuilderTests.cs index 3d743d5a..037f9e4f 100644 --- a/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/HttpMessageHandlers/ResponseMocking/HttpResponseMessageMockBuilderTests.cs +++ b/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/HttpMessageHandlers/ResponseMocking/HttpResponseMessageMockBuilderTests.cs @@ -26,7 +26,7 @@ public void Where2ValidateArguments() } /// - /// Validates the arguments for the method. + /// Validates the arguments for the method. /// [Fact] public void Respond1WithValidateArguments() diff --git a/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/OutOfProcess/ResponseBasedHttpMockServerBuilderTests.cs b/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/OutOfProcess/ResponseBasedHttpMockServerBuilderTests.cs index 1e6ce8cc..56d6d49d 100644 --- a/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/OutOfProcess/ResponseBasedHttpMockServerBuilderTests.cs +++ b/tests/DotNet.Sdk.Extensions.Testing.Tests/HttpMocking/OutOfProcess/ResponseBasedHttpMockServerBuilderTests.cs @@ -42,7 +42,7 @@ public async Task RepliesAsConfigured2() /// In linux this test fails with error: /// System.Net.Http.HttpRequestException : The SSL connection could not be established, see inner exception. /// because dev certificate does not exist - /// For more info on how to resolve this issue see: https://docs.microsoft.com/en-us/aspnet/core/security/enforcing-ssl?view=aspnetcore-5.0&tabs=visual-studio#ssl-linux. + /// For more info on how to resolve this issue see: https://docs.microsoft.com/en-us/aspnet/core/security/enforcing-ssl#ssl-linux. /// [Fact] public async Task RepliesAsConfigured()