Skip to content

Commit 66d2245

Browse files
authored
Silicon/RK3588: Fix COMBO_PHY_MODE_SATA typo (#103)
Not sure that it matters, but there is an apparent typo in the value given to PIPE_PHY_GRF_PIPE_CON3 for COMBO_PHY_MODE_SATA. The '4' is probably off by one digit. Reset value is 0x0002. Existing SATA-mode value is 0x0407 (pipe_sel=PCIe): - `0` = qsgm=0, pipe_sel=**00 (PCIe)**, reserved=0. - `4` = clkreq=0, rxelecidle=**1**, clk_ref_src=00. - `0` = reserved=0000. - `7` = txpattern_sata=0, txmargin=1, txdeemph=1, txswing=1. Likely intended value is 0x4007 (pipe_sel=SATA): - `4` = qsgm=0, pipe_sel=**10 (SATA)**, reserved=0. - `0` = clkreq=0, rxelecidle=**0**, clk_ref_src=00. - `0` = reserved=0000. - `7` = txpattern_sata=0, txmargin=1, txdeemph=1, txswing=1.
1 parent e3a793c commit 66d2245

File tree

1 file changed

+1
-1
lines changed
  • edk2-rockchip/Silicon/Rockchip/RK3588/Drivers/RK3588Dxe

1 file changed

+1
-1
lines changed

edk2-rockchip/Silicon/Rockchip/RK3588/Drivers/RK3588Dxe/ComboPhy.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ InitComPhyConfig (
8787
MmioWrite32 (PhpBaseAddr + 0x0, 0xFFFF0129);
8888
MmioWrite32 (PhpBaseAddr + 0x4, 0xFFFF4000);
8989
MmioWrite32 (PhpBaseAddr + 0x8, 0xFFFF80c1);
90-
MmioWrite32 (PhpBaseAddr + 0xc, 0xFFFF0407);
90+
MmioWrite32 (PhpBaseAddr + 0xc, 0xFFFF4007);
9191

9292
/* Should we tune the rest of the parameters too? */
9393

0 commit comments

Comments
 (0)