Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Scanner page from Versionista url #203

Closed
weatherpattern opened this issue Feb 14, 2018 · 5 comments
Closed

Display Scanner page from Versionista url #203

weatherpattern opened this issue Feb 14, 2018 · 5 comments

Comments

@weatherpattern
Copy link
Contributor

Problem: Sheets still contain links to Versionista. It is easier to to look them up in Versionista than go back to Scanner and find the correct dates manually.

Possible Solution:
Implement new feature in Scanner search to accept versionista links. The search will map the submitted link to the same view in Scanner.

@Mr0grog
Copy link
Member

Mr0grog commented Feb 15, 2018

NOTE: this issue is mostly for tracking so we don’t forget about this right now. It’s low priority, but as we get closer to switching over to other data sources, we’ll want to make sure to revisit this and see if we still feel we need to do it.

@weatherpattern
Copy link
Contributor Author

Also, another option was to go through and rewrite the links to the sheets, but analysts were wary of losing data. Also, in the future, it might be helpful to know that annotations were created using the original diffs, instead Scanner diffs. So, maintain that information is important.

Adding extra columns to keep both sets of links was floated, but that would cause problems as information could not be cut and past as analysts currently do.

@Mr0grog
Copy link
Member

Mr0grog commented Feb 15, 2018

it might be helpful to know that annotations were created using the original diffs, instead Scanner diffs. So, maintain that information is important.

The task of importing those annotations is sorta-kinda tracked here: edgi-govdata-archiving/web-monitoring-db#61

Would be good to add that note there (that an annotation imported from sheets should have a field indicating that’s where it came from).

@weatherpattern weatherpattern changed the title Display Scanner page from Verisonista url Display Scanner page from Versionista url Feb 15, 2018
@Mr0grog
Copy link
Member

Mr0grog commented Mar 16, 2018

So, to clarify here, what we’re saying is:

If you browse to /pages or /assignedPages and enter a URL in the search field like:

http://versionista.com/####
http://versionista.com/####/####
http://versionista.com/####/####/####
http://versionista.com/####/####/####:####

We should display links to any pages we have that match that page in Versionista instead of normal search results. e.g:

  • Searching for https://versionista.com/104601/ would yield two pages:

    • 56518be0-edfb-468f-97d5-ac94710a2072
    • 6943e889-af33-4001-8d40-69962a4b48ce

    Because those pages are the only ones with version records that have source_type=versionista&source_metadata[site_id]=104601

  • Searching for https://versionista.com/104601/8183986/ would yield one page:

    • 6943e889-af33-4001-8d40-69962a4b48ce

    Because that is the page with version records that have source_type=versionista&source_metadata[page_id]=8183986

But these two are kinda complicated because the search results normally lists pages, not particular versions:

  • Searching for https://versionista.com/104601/8183986/14394309/ would yield a link to a specific version of a page, which is not really something the list view supports right now:

    • Version 38753208-d8b0-460b-80af-d77d44d9aa32

    Because that is the version records that matches source_type=versionista&source_metadata[version_id]=14394309

  • Searching for https://versionista.com/104601/8183986/14394309:13585098/ would yield a link to a specific two versions of a page, which is not really something the list view supports right now:

    • Versions 97651956-3156-4414-ba6d-dafb50c85fca..38753208-d8b0-460b-80af-d77d44d9aa32

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2019
@stale stale bot closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants