Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last modified date #84

Open
ericnost opened this issue Aug 25, 2020 · 4 comments
Open

Add last modified date #84

ericnost opened this issue Aug 25, 2020 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ericnost
Copy link
Member

Last-Modified data as returned from the ECHO EPA server

http://apps.tlt.stonybrook.edu/echoepa/?query=select%20*%20from%20%22Last-Modified%22&pg

Perhaps we can add a property "last_modified" to the data set class, something that goes and gets the value from the "modified" field in this table for each table...

@ericnost ericnost added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 25, 2020
@shansen5
Copy link
Collaborator

shansen5 commented Aug 31, 2020

I see that each table can have a different 'modified' date stamp, so we will get this per dataset. Since it will be the same for all DataSetResults, we don't need to get it each time results are obtained.
(I'll put this into a branch of ECHO_modules.)

@shansen5
Copy link
Collaborator

A slight complication in that Last-Modified has the table names (e.g. RCRA_VIOLATIONS), while we are using the views based on them (RCRA_VIOLATIONS_MVIEW). I'll have to add something like base_table_name to each of the DataSet objects when they are created in make_data_sets().

@shansen5
Copy link
Collaborator

shansen5 commented Sep 1, 2020

A new base_table was added to each DataSet instance identifying the database table that reflects the data set's last modified time. In the DataSet's get_data() function the last_modified time is set if it hasn't already been done.

@Frijol
Copy link
Contributor

Frijol commented Oct 12, 2021

What's the use context for this date? How do we hope to incorporate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants