Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While fixing county names from ECHO_EXPORTER, also look for the word PARISH #65

Open
shansen5 opened this issue Jul 22, 2020 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@shansen5
Copy link
Collaborator

The ECHO_EXPORTER has different names for the same county in many cases. It shows both WHATCOM and WHATCOM COUNTY, for example. In Louisiana it will show both ORLEANS and ORLEANS PARISH. There is code to catch the COUNTY and reflect that it is the same name, but we should also catch PARISH.

@Frijol Frijol added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Oct 12, 2021
@Frijol
Copy link
Contributor

Frijol commented Oct 12, 2021

@shansen5 is this specific to any one of the Notebooks in this repo?

@ctsiagkalis
Copy link
Contributor

I could work on this, but I think there are more problems like this one. Maybe the data in the csv should be cleaned instead of doing this programmatically. Some of the names that probably need fixing are:

AK,ALEUTIANS EAST
AK,ALEUTIANS EAST (B)
AK,ALEUTIANS EAST BOROUGH

AK,ALEUTIANS WEST
AK,ALEUTIANS WEST (CA)
AK,ALEUTIANS WEST CENSUS AREA

PA,CRAWFORD
PA,CRAWFORD CO. PA

PR,ADJUNTAS
PR,ADJUNTAS MUNICIPIO

OK,STEPHENS
OK,STEPHENSSTEPHENS

VA,EMPORIA
VA,EMPORIA (CITY)
VA,EMPORIA CITY

VA,PRINCE GEORGE
VA,PRINCE GEORGE'S

VI,SAINT CROIX
VI,SAINT CROIX ISLAND

If you still think we only need to catch PARISH, let me know and I will create a PR.

@shansen5
Copy link
Collaborator Author

As this is data we download from the EPA and put into our database we can't really fix it in the CSV.
There is a fix_county_names() in ECHO_modules/utilities.py, which is only for displaying the name once in our dropdown list when there is both a SOMECOUNTY and SOMECOUNTY COUNTY in ECHO_EXPORTER.
Open to ideas of how we can do this more generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants