Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange/empty graphs for quarters out of compliance in cell #5 #133

Closed
Frijol opened this issue Oct 11, 2021 · 1 comment
Closed

Strange/empty graphs for quarters out of compliance in cell #5 #133

Frijol opened this issue Oct 11, 2021 · 1 comment
Assignees
Labels
good first issue Good for newcomers hacktoberfest invalid This doesn't seem right

Comments

@Frijol
Copy link
Contributor

Frijol commented Oct 11, 2021

Notebook: https://colab.research.google.com/github/edgi-govdata-archiving/ECHO-Cross-Program/blob/main/ECHO-Cross-Programs.ipynb#scrollTo=tGG4dLXuaRLN

Empty graphs for CAA and RCRA are confusing. The top one shows two violators, but there are no quarters in violation. The second graph gives no violators and has no title (I assume it's RCRA?)

It would be better to just not show the graph if there are no quarters out of compliance.

To reproduce:

Set Zip Code 98103 and run cell 5 to chart violators.

To close:

Only display graphs in this cell for categories of regulation that have violators. Otherwise, print that there are no violators for the region in that category.

@Frijol Frijol added good first issue Good for newcomers invalid This doesn't seem right hacktoberfest labels Oct 11, 2021
@ericnost ericnost self-assigned this Oct 27, 2021
@ericnost
Copy link
Member

Looks like this issue has been fixed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants