Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use TypedDict for more precise **kwargs typing #765

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Mar 18, 2023

@trunk-io
Copy link

trunk-io bot commented Mar 18, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b903776) 100.00% compared to head (f32d232) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #765   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          386       386           
  Branches        20        20           
=========================================
  Hits           386       386           
Impacted Files Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 18, 2023 02:30
@edgarrmondragon edgarrmondragon merged commit f355731 into main Mar 18, 2023
@edgarrmondragon edgarrmondragon deleted the chore/TypedDict-kwargs branch March 18, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant