Skip to content

Use Java reflection to get ORC date stats. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edgarRd merged 1 commit into from
Jun 27, 2020
Merged

Use Java reflection to get ORC date stats. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,18 @@

import java.io.IOException;
import java.nio.ByteBuffer;
import java.sql.Date;
import java.sql.Timestamp;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Queue;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import java.util.stream.Stream;
import org.apache.hadoop.conf.Configuration;
import org.apache.iceberg.Metrics;
import org.apache.iceberg.Schema;
import org.apache.iceberg.common.DynFields;
import org.apache.iceberg.exceptions.RuntimeIOException;
import org.apache.iceberg.hadoop.HadoopInputFile;
import org.apache.iceberg.io.InputFile;
Expand All @@ -43,7 +44,6 @@
import org.apache.iceberg.types.Conversions;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
import org.apache.iceberg.util.DateTimeUtil;
import org.apache.orc.BooleanColumnStatistics;
import org.apache.orc.ColumnStatistics;
import org.apache.orc.DateColumnStatistics;
Expand All @@ -55,6 +55,7 @@
import org.apache.orc.TimestampColumnStatistics;
import org.apache.orc.TypeDescription;
import org.apache.orc.Writer;
import org.apache.orc.impl.ColumnStatisticsImpl;

public class OrcMetrics {

Expand Down Expand Up @@ -157,9 +158,7 @@ private static Optional<ByteBuffer> fromOrcMin(Types.NestedField column,
.setScale(((Types.DecimalType) column.type()).scale()))
.orElse(null);
} else if (columnStats instanceof DateColumnStatistics) {
min = Optional.ofNullable(((DateColumnStatistics) columnStats).getMinimum())
.map(minStats -> DateTimeUtil.daysFromDate(((Date) minStats).toLocalDate()))
.orElse(null);
min = Optional.ofNullable(minDayFromEpoch((DateColumnStatistics) columnStats)).orElse(null);
} else if (columnStats instanceof TimestampColumnStatistics) {
TimestampColumnStatistics tColStats = (TimestampColumnStatistics) columnStats;
Timestamp minValue = tColStats.getMinimumUTC();
Expand Down Expand Up @@ -195,9 +194,7 @@ private static Optional<ByteBuffer> fromOrcMax(Types.NestedField column,
.setScale(((Types.DecimalType) column.type()).scale()))
.orElse(null);
} else if (columnStats instanceof DateColumnStatistics) {
max = Optional.ofNullable(((DateColumnStatistics) columnStats).getMaximum())
.map(maxStats -> DateTimeUtil.daysFromDate(((Date) maxStats).toLocalDate()))
.orElse(null);
max = Optional.ofNullable(maxDayFromEpoch((DateColumnStatistics) columnStats)).orElse(null);
} else if (columnStats instanceof TimestampColumnStatistics) {
TimestampColumnStatistics tColStats = (TimestampColumnStatistics) columnStats;
Timestamp maxValue = tColStats.getMaximumUTC();
Expand Down Expand Up @@ -272,4 +269,27 @@ public TypeDescription primitive(Type.PrimitiveType iPrimitive, TypeDescription
return primitive;
}
}

private static final Class<?> DATE_STATS_IMPL = Stream.of(ColumnStatisticsImpl.class.getDeclaredClasses())
.filter(statsClass -> "DateStatisticsImpl".equals(statsClass.getSimpleName()))
.findFirst()
.orElse(null);

private static final DynFields.UnboundField<Integer> DATE_MINIMUM = DynFields.builder()
.hiddenImpl(DATE_STATS_IMPL, "minimum")
.defaultAlwaysNull() // if the minimum field isn't found, don't add a value
.build();

private static final DynFields.UnboundField<Integer> DATE_MAXIMUM = DynFields.builder()
.hiddenImpl(DATE_STATS_IMPL, "maximum")
.defaultAlwaysNull() // if the minimum field isn't found, don't add a value
.build();

private static Integer minDayFromEpoch(DateColumnStatistics stats) {
return DATE_MINIMUM.get(stats);
}

private static Integer maxDayFromEpoch(DateColumnStatistics stats) {
return DATE_MAXIMUM.get(stats);
}
}