Skip to content

Commit 5862e1f

Browse files
authored
don't use logging.basicConfig (#47)
* replace basicConfig with setLevel and addHandler * avoid duplicate handlers
1 parent 85351e4 commit 5862e1f

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

cdsapi/api.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,14 @@ def __init__(
271271
else:
272272
level = logging.INFO
273273

274-
logging.basicConfig(
275-
level=level, format="%(asctime)s %(levelname)s %(message)s"
276-
)
274+
self.logger.setLevel(level)
275+
276+
# avoid duplicate handlers when creating more than one Client
277+
if not self.logger.handlers:
278+
formatter = logging.Formatter("%(asctime)s %(levelname)s %(message)s")
279+
handler = logging.StreamHandler()
280+
handler.setFormatter(formatter)
281+
self.logger.addHandler(handler)
277282

278283
dotrc = os.environ.get("CDSAPI_RC", os.path.expanduser("~/.cdsapirc"))
279284

0 commit comments

Comments
 (0)