bug/2243 Users without the Publish Permission on a namespace can see … #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Publish button * changed the pre-authorization of ModelRepositoryController#getPolicies to all users * added call to above endpoint in detailsController to infer whether user can publish * replaced permission check in template to use flag from controller rather than full access permission Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
ghost
mentioned this pull request
kolotu
approved these changes
Jan 22, 2020
And the user is inferred in the back-end, not given by the front-end, so there's no using this endpoint to check on permissions for other users either. |
kolotu
deleted the
bug/2243_Users_without_the_Publish_Permission_on_a_namespace_can_see_the_Publish_button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the Publish button
Signed-off-by: Menahem Julien Raccah Lisei [email protected]