Feature/2208 creating a technical user should require a subject #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jan 9, 2020
ghost
commented
- modal for technical user creation now also prompts for subject (required, pattern-validated)
- DTO, controller and back-end now validate, handle and persist the subject
- few changes in adding user to tenant, e.g. button disabled until some username typed (previous implementation was not working and loading animations are still useless pretty much all over the place still now)
- added some failsafes when handling search vs actual usernames in form
- Created a few tests for tech user creation regarding subject
* modal for technical user creation now also prompts for subject (required, pattern-validated) * DTO, controller and back-end now validate, handle and persist the subject * few changes in adding user to tenant, e.g. button disabled until some username typed (previous implementation was not working and loading animations are still useless pretty much all over the place still now) * added some failsafes when handling search vs actual usernames in form Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
* Created a few tests for tech user creation regarding subject Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
ghost
mentioned this pull request
…pe pollution * changed jquery to 3.4.1 Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
…ble_to_prototype_pollution' into feature/2208_Creating_a_technical_user_should_require_a_subject
kolotu
deleted the
feature/2208_Creating_a_technical_user_should_require_a_subject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.