Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2088 namespace admin is able to create a technical user for a namespace #2192

Merged
merged 10 commits into from
Jan 9, 2020
Merged

Feature/2088 namespace admin is able to create a technical user for a namespace #2192

merged 10 commits into from
Jan 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2019 •
edited by ghost
Loading

@aedelmann @erlemantos I am pull-requesting this change set as is, as it's been a while and I will be back to work on January 7th.

A few things worth noticing:

  1. The coverage as I intended is incomplete. I was supposed to finalize that last Friday (Dec 27th) but was too sick with the flu to get anything done. I only have 3 integration tests at the controller level (see AccountControllerTest). Depending on whether this is suitable for merging as is or not, I can create a separate task to finalize on my originally intended coverage (e.g. in TenantServiceTest and UserAccountServiceTest).
  2. We originally discussed with @aedelmann that the UX improvement to search users when adding users to namespaces (so you don't have to blackbox type in a username and not know whether they exist or not right away) was to be pushed in a different branch. I ended up integrating this change within the same branch as Specify and store the provider ID of a collaborator #2088, as the UI part is "doing the job". If we really want to take it out and rework it, I can simply revert the UI part and keep the controller / back-end code.
  3. @aedelmann even assuming this does not break anything (which I will see for myself in a while) please check the branch out and have a look around before merging. Given the history of Specify and store the provider ID of a collaborator #2088 I am not entirely sure this is ok as is, or needs improvement. I was not able to get a hold of @erlemantos during the xmas period, so I could not get additional confirmations.

Feel free to drop me a message during my absence - I will check from time to time and decide the best course of action.

@kolotu for visibility.

Happy holidays!

@menajrl
eclipse-vorto#2088:
629fae0 
* end-to-end workflow for technical user creation when adding a non-existing user to a namespace:
   1. Admin edits collaborators in a given namespace
   2. Admin selects "add user"
   3. Given username does not exist
   4. A new modal opens, prompting admin to create a new technical user with a given authorization provider ID among supported
   5. Once created, modals close and the new technical user is created

* no tests present yet

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
@menajrl
eclipse-vorto#2088:
d5c8291 
Small UI/UX improvements:

* nicer design /spacing for the new "create technical user form"
* add user autofocuses on the user name input box

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
@menajrl
eclipse-vorto#2088:
0b8a898 
Large UI/UX improvements:

* User search when adding to namespace, with a drop down activating once user input field text length is >= 4 characters
* Search retrieves users whose name contains search characters, shows and adds to drop-down
* If no option selected or none available, username interpreted as is (can still be added as non-existing / technical user then)

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
@menajrl
Merge branch 'development' into feature/2088_Namespace_admin_is_able_…
416f3d5 
…to_create_a_technical_user_for_a_namespace
@menajrl
eclipse-vorto#2088:
70de7f3 
* Made user search case-insensitive (not well optimized, sadly)
* Added a few tests for search
* Removed some extraneous import in TenantTechnicalUserDto

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
@ghost ghost mentioned this pull request Dec 29, 2019
Closed
menajrl added 5 commits January 7, 2020 16:14
@menajrl
eclipse-vorto#2088:
def386a 
* Cleaned up some code
* Added some javadoc where missing
* Added a couple of account service tests (note that user and tenant repositories are mocked by the parent class, so the only applicable tests are the ones that will fail due to validation issues)

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
@menajrl
eclipse-vorto#2088:
dee6a6e 
* Minimal javadoc on new tests

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
@menajrl
eclipse-vorto#2088:
46bc35b 
* Improved combobox
* Cleaned up some garbage

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
@menajrl
Merge branch 'development' into feature/2088_Namespace_admin_is_able_…
94811f6 
…to_create_a_technical_user_for_a_namespace
@menajrl
Merge branch 'development' into feature/2088_Namespace_admin_is_able_…
cc643dc 
…to_create_a_technical_user_for_a_namespace
@aedelmann aedelmann merged commit 1d174ed into eclipse-vorto:development Jan 9, 2020
@aedelmann aedelmann deleted the feature/2088_Namespace_admin_is_able_to_create_a_technical_user_for_a_namespace branch January 9, 2020 01:43
JulianFeinauer pushed a commit to JulianFeinauer/vorto that referenced this pull request Jun 27, 2020
@JulianFeinauer
Feature/2088 namespace admin is able to create a technical user for a…
07c350d 
… namespace (eclipse-vorto#2192)

* eclipse-vorto#2088:

* end-to-end workflow for technical user creation when adding a non-existing user to a namespace:
   1. Admin edits collaborators in a given namespace
   2. Admin selects "add user"
   3. Given username does not exist
   4. A new modal opens, prompting admin to create a new technical user with a given authorization provider ID among supported
   5. Once created, modals close and the new technical user is created

* no tests present yet

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>

* eclipse-vorto#2088:

Small UI/UX improvements:

* nicer design /spacing for the new "create technical user form"
* add user autofocuses on the user name input box

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>

* eclipse-vorto#2088:

Large UI/UX improvements:

* User search when adding to namespace, with a drop down activating once user input field text length is >= 4 characters
* Search retrieves users whose name contains search characters, shows and adds to drop-down
* If no option selected or none available, username interpreted as is (can still be added as non-existing / technical user then)

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>

* eclipse-vorto#2088:

* Made user search case-insensitive (not well optimized, sadly)
* Added a few tests for search
* Removed some extraneous import in TenantTechnicalUserDto

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>

* eclipse-vorto#2088:

* Cleaned up some code
* Added some javadoc where missing
* Added a couple of account service tests (note that user and tenant repositories are mocked by the parent class, so the only applicable tests are the ones that will fail due to validation issues)

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>

* eclipse-vorto#2088:

* Minimal javadoc on new tests

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>

* eclipse-vorto#2088:

* Improved combobox
* Cleaned up some garbage

Signed-off-by: Menahem Julien Raccah Lisei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aedelmann @menajrl