Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation through Model Repository does not work when using GeneratorServiceInfo Class from Version 0.9.0 #596

Closed
marcusmunzert opened this issue Jun 14, 2017 · 2 comments
Labels
Milestone

Comments

@marcusmunzert
Copy link

We have a code generator "IoT Gateway for Kura (with Vorto-Models)" registered with Vorto. That code generator is executed on our Virtual Developer platform when someone selects an information model on the Vorto model repository and clicks on "Generate". We use the class GeneratorServiceInfo (contained in artifact org.eclipse.vorto.codegen) from the released version 0.9.0 of Vorto to provide the generator metadata. That class does not yet include the fields "configTemplate" and "configKeys" (in 0.10.0 they are included). So the actual model repository web app somehow depends on Vorto 0.10.0. For our generator a click on "Generate" causes an error in the JavaScript function "generate" in controllers.js.

As a workaround we simply have copied two source code files from 0.10.0 to use them to provide the JSON data. A better, more general solution might be to modify the JavaScript "generate" function to not depend on the presence of "configTemplate" and "configKeys" in the JSON data.

Please note that at the time of writing this issue, a ready built version (e.g. SNAPSHOT) of 0.10.0 is not publicly available.

@aedelmann aedelmann added the bug label Jun 14, 2017
@aedelmann
Copy link
Contributor

Hi Markus,
we are gonna provide a fix in the javascript and deploy it by tmr.
Thanks for the hint!

Cheers, Alex

@aedelmann
Copy link
Contributor

Hi Marcus

We rolled out the fix. Can u please verify ?
Thanks.

Alex

@aedelmann aedelmann added this to the 0.10.0-M1 milestone Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants