Enable container support by default #3184
Conversation
|
fyi - @mpirvu |
runtime/vm/jvminit.c
Outdated
| @@ -1890,7 +1890,7 @@ IDATA VMInitStages(J9JavaVM *vm, IDATA stage, void* reserved) { | |||
| argIndex = FIND_AND_CONSUME_ARG(EXACT_MATCH, VMOPT_XXUSECONTAINERSUPPORT, NULL); | |||
| argIndex2 = FIND_AND_CONSUME_ARG(EXACT_MATCH, VMOPT_XXNOUSECONTAINERSUPPORT, NULL); | |||
|
|
|||
| if (argIndex > argIndex2) { | |||
| if ((-1 == argIndex2) || (argIndex > argIndex2)) { | |||
There was a problem hiding this comment.
If neither option is specified, the argIndex's will be the same. Isn't it sufficient to do if (argIndex >= argIndex2) plus add a comment to indicate that -XX:+ContainerSupport is the default?
There was a problem hiding this comment.
that would work as well.
|
Jenkins test sanity plinux,aix,win jdk8 |
|
Thrown some heavier testing at this to validate platforms where -XX:ContainerSupport won't have any effect |
Enable container support by default. To disable container support use -XX:-UseContainerSupport option. Signed-off-by: Ashutosh Mehra <[email protected]>
ashu-mehra
force-pushed
the
enable_container_support_default
branch
from
7aae135 to
0a5212d
Compare
|
Updated the condition as suggested. |
|
Jenkins test sanity plinux,aix,win jdk8 |
|
@SueChaplain fyi a new doc change. |
|
@ashu-mehra please create an issue at https://github.com/eclipse/openj9-docs for the change in behavior. |
|
@pshipton created eclipse-openj9/openj9-docs#106 for the doc changes. |
Enable container support by default. To disable container support
use -XX:-UseContainerSupport option.
Doc issue eclipse-openj9/openj9-docs#106
Fixes: #2263
Signed-off-by: Ashutosh Mehra [email protected]