Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and bundle an openssl library with OpenJ9 builds #3118

Closed
pshipton opened this issue Oct 3, 2018 · 9 comments · Fixed by #3250
Closed

Enable and bundle an openssl library with OpenJ9 builds #3118

pshipton opened this issue Oct 3, 2018 · 9 comments · Fixed by #3250

Comments

@pshipton
Copy link
Member

pshipton commented Oct 3, 2018

The OpenJ9 0.11.0 release is coming in Oct, with final builds created for Oct 19.

One of the features [1] of the release is using the openssl 1.1.x library, which we'd like to bundle with the OpenJ9 Java 8 build for the time being.
[1] ibmruntimes/openj9-openjdk-jdk8#112

There is a choice to use a pre-built openssl library installed on the build machines (including header files), however this means the machines will need to be updated every time there is a security fix required. This affects all platforms: Windows 32-bit, 64-bit, Linux, AIX, macOS (later).

If you use pre-built OpenSSL binary, then

use the following configure option, --with-openssl=path_to_openssl_library and --enable-openssl-bundling

If you are building openssl binary with openJDK8, then

use --openssl-version=1.1.XX with ‘bash get_source.sh’ command. (NOTE : For Windows platform, building openssl from source along with OpenJDK8 had a known issue and has to use pre-built openssl binary); and
use the following configure option, --with-openssl=fetched and --enable-openssl-bundling
@pshipton pshipton added this to the Release 0.11.0 milestone Oct 3, 2018
@pshipton
Copy link
Member Author

pshipton commented Oct 3, 2018

@jdekonin

@pshipton
Copy link
Member Author

pshipton commented Oct 3, 2018

I expect openssl 1.1.1 should be used since it is the latest stable version and the LTS version.
https://www.openssl.org/source/

@pshipton
Copy link
Member Author

pshipton commented Oct 3, 2018

Issue at Adopt adoptium/temurin-build#604

jdekonin added a commit to jdekonin/openj9 that referenced this issue Oct 5, 2018
* [skip ci]
* Addresses eclipse-openj9#3118
* all platforms; windows 32/64, xlinux, xlinux large heap, plinux, zlinux, aix
* JDK8, JDK11, next

Signed-off-by: Joe deKoning <[email protected]>
jdekonin added a commit to jdekonin/openj9 that referenced this issue Oct 5, 2018
* [skip ci]
* Addresses eclipse-openj9#3118
* all platforms; windows 32/64, xlinux, xlinux large heap, plinux, zlinux, aix
* JDK8 only

Signed-off-by: Joe deKoning <[email protected]>
jdekonin added a commit to jdekonin/openj9 that referenced this issue Oct 5, 2018
* [skip ci]
* Addresses eclipse-openj9#3118
* platforms: xlinux cmake, xlinux, xlinux large heap, plinux, zlinux, aix
* JDK8 only

Signed-off-by: Joe deKoning <[email protected]>
@pshipton
Copy link
Member Author

pshipton commented Oct 5, 2018

Note the Windows restriction still applies. You must run configure with --with-openssl=/path/to/pre-built/openssl

@pshipton
Copy link
Member Author

pshipton commented Oct 5, 2018

Enabled for xlinux and plinux via #3169
aix and zlinux are failing to build
ibmruntimes/openj9-openjdk-jdk8#123
ibmruntimes/openj9-openjdk-jdk8#122

@pshipton
Copy link
Member Author

pshipton commented Oct 9, 2018

AIX #3189 and Windows #3191 are enabled now.

@pshipton
Copy link
Member Author

pshipton commented Oct 12, 2018

@vsebe @jdekonin we can use this issue. Since zlinux cannot automatically build 1.1.1 from source atm, we can use a pre-built binary on this platform.

wget https://www.openssl.org/source/openssl-1.1.1.tar.gz
tar -xf openssl-1.1.1.tar.gz
cd openssl-1.1.1
./Configure linux64-s390x
[ Apply patch from https://github.com/openssl/openssl/pull/7239/commits/69dd4fd2499db20454b0e7a7d9a9764dcc6f0035 ]
make

@jdekonin
Copy link
Contributor

Setup on the 4 zLinux 390 machines in /home/jenkins/openssl-1.1.1.

@pshipton
Copy link
Member Author

pshipton commented Oct 12, 2018

@jdekonin thanks. The next step is to update defaults.yml to pass --with-openssl=/home/jenkins/openssl-1.1.1 --enable-openssl-bundling

jdekonin added a commit to jdekonin/openj9 that referenced this issue Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants