Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Databroker Git version information in container seems to be incorrect #516

Open
SebastianSchildt opened this issue Mar 20, 2023 · 2 comments
Labels
bug Something isn't working might not get fixed These issues might not get fixed and are just for documentation purposes here

Comments

@SebastianSchildt
Copy link
Contributor

This came up in review of #506

Solution are not elegant, but easy

In git checkout action no tags are available, and can neither be checked, options are

@lukasmittag lukasmittag added bug Something isn't working might not get fixed These issues might not get fixed and are just for documentation purposes here labels Apr 18, 2023
@SebastianSchildt
Copy link
Contributor Author

Maybe we should think about it in terms of Github Releases: Those should be automated via GH actions, and there we shoudl decide the "correct" way to determine version information

@erikbosch
Copy link
Contributor

As a comment. For kuksa-python-sdk we do not do a shallow clone in CI. Is the size actually a problem?

    - uses: actions/checkout@v4
      with:
        # Fetch everything to get tags working as expected
        fetch-depth: 0
        submodules: 'true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working might not get fixed These issues might not get fixed and are just for documentation purposes here
Projects
None yet
Development

No branches or pull requests

3 participants