Non-existing targets are not added to assignment count #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 2, 2019 14:59
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 5, 2019 12:53
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
bogdan-bondar
requested changes
Dec 9, 2019
hawkbit-rest/hawkbit-rest-docs/src/main/asciidoc/distributionsets-api-guide.adoc
Outdated
Show resolved
Hide resolved
...ce/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtDistributionSetResourceTest.java
Outdated
Show resolved
Hide resolved
...ce/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtDistributionSetResourceTest.java
Outdated
Show resolved
Hide resolved
...ce/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtDistributionSetResourceTest.java
Show resolved
Hide resolved
...ce/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtDistributionSetResourceTest.java
Outdated
Show resolved
Hide resolved
...-repository-test/src/main/java/org/eclipse/hawkbit/repository/test/util/TestdataFactory.java
Outdated
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
added 10 commits
December 12, 2019 10:17
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
Signed-off-by: Sebastian Firsching <[email protected]>
schabdo
changed the title
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
* Dont count not existing targets as already assigned to DS Signed-off-by: Sebastian Firsching <[email protected]> * Add test for deploymentManagement Signed-off-by: Sebastian Firsching <[email protected]> * Delete 404 error message from docs when target is not found Signed-off-by: Sebastian Firsching <[email protected]> * Add text to implementation notes Signed-off-by: Sebastian Firsching <[email protected]> * Add assertions to test Signed-off-by: Sebastian Firsching <[email protected]> * Add expected behaviour to test description Signed-off-by: Sebastian Firsching <[email protected]> * Refactor deploymentMgmtTest Signed-off-by: Sebastian Firsching <[email protected]> * Filter out non-existing controllerIds Signed-off-by: Sebastian Firsching <[email protected]> * Extend test descriptions Signed-off-by: Sebastian Firsching <[email protected]> * Refactor createTargets method Signed-off-by: Sebastian Firsching <[email protected]> * Add createTargetAndJsonArray method Signed-off-by: Sebastian Firsching <[email protected]> * Correct expected test result Signed-off-by: Sebastian Firsching <[email protected]> * Adapt rest docs Signed-off-by: Sebastian Firsching <[email protected]> * Correct test Signed-off-by: Sebastian Firsching <[email protected]> * Only count targets that exist for total and adapt test Signed-off-by: Sebastian Firsching <[email protected]> * Use only existign targetWithActionTypes for assignment Signed-off-by: Sebastian Firsching <[email protected]> * Rename targetIds to providedTargetIds Signed-off-by: Sebastian Firsching <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assigning multiple targets to a distribution set, not existing targets are silently ignored. The already assigned count was not calculated correctly in this case. This pull request is a fix for this calculation.