Error message not shown in case filesize is exceeded #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Dobler <[email protected]>
dobleralex
commented
Nov 4, 2019
...i/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/FileTransferHandlerVaadinUpload.java
Show resolved
Hide resolved
dobleralex
commented
Nov 4, 2019
...i/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/FileTransferHandlerVaadinUpload.java
Outdated
Show resolved
Hide resolved
dobleralex
commented
Nov 4, 2019
...it-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/AbstractFileTransferHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander Dobler <[email protected]>
Signed-off-by: Alexander Dobler <[email protected]>
blomark
reviewed
Nov 4, 2019
...it-ui/src/main/java/org/eclipse/hawkbit/ui/artifacts/upload/AbstractFileTransferHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander Dobler <[email protected]>
schabdo
changed the title
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
…t#906) * Fixed message not showing when exceeding filesize Signed-off-by: Alexander Dobler <[email protected]> * Also use fixed max filesize approach during drag and drop Signed-off-by: Alexander Dobler <[email protected]> * Moved log messages and adjusted upload log levels Signed-off-by: Alexander Dobler <[email protected]> * Further adjustments of logging Signed-off-by: Alexander Dobler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when trying to upload a file that exceeds the max allowed file size of spring. The upload was rejected, but this was not visible in the UI. It just showed the progress bar but did not do anything.
With this PR it will notify the UI properly and provide a message why the upload failed.