Correct outdated RabbitMQ listener properties #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalia Kislicyn <[email protected]>
Signed-off-by: Natalia Kislicyn <[email protected]>
|
Can one of the admins verify this patch? |
schabdo
changed the title
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
* Rename dmf defaults properties to config rabbitmq's simple listener Signed-off-by: Natalia Kislicyn <[email protected]> * set rabbitmq listener prefetch and concurrency properties Signed-off-by: Natalia Kislicyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Spring AMQP version 2 the listener properties' names changed depending on the container that is used, e.g. spring.rabbitmq.listener.simple.key when using SimpleMessageListenerContainer.
For the prefetch property also the default value has changed to 250, which is set here explicitly to that value to stay stable in case of further changes.
The concurrency's min and max values are set from 1 (initial default) to 10 to avoid uncontrollably concurrency adjusting when the workload is increasing.