Allow assignment of multiple distribution sets to a target via Mgmt-API #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StefanKlt please verify the commit history and double check the signed-offs. |
StefanKlt
commented
Sep 5, 2019
...ory/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/QuotaManagement.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 5, 2019
...ava/org/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtTargetAssignmentRequestBody.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Sep 5, 2019
...rest/hawkbit-mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/rest/api/MgmtTargetRestApi.java
Show resolved
Hide resolved
StefanKlt
commented
Sep 5, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
StefanKlt
commented
Sep 5, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
StefanKlt
commented
Sep 5, 2019
hawkbit-rest/hawkbit-rest-docs/src/main/asciidoc/targets-api-guide.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
one request Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
Signed-off-by: Stefan Klotz <[email protected]>
StefanKlt
force-pushed
the
feature_multiassignment_via_mgmt
branch
from
ef2089b to
ef69a06
Compare
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
stefbehl
reviewed
Sep 9, 2019
...awkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/DeploymentManagement.java
Show resolved
Hide resolved
stefbehl
reviewed
Sep 9, 2019
...awkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/DeploymentManagement.java
Outdated
Show resolved
Hide resolved
stefbehl
reviewed
Sep 9, 2019
...main/java/org/eclipse/hawkbit/repository/exception/MultiassignmentIsNotEnabledException.java
Outdated
Show resolved
Hide resolved
stefbehl
reviewed
Sep 9, 2019
...bit-repository-api/src/main/java/org/eclipse/hawkbit/repository/model/DeploymentRequest.java
Show resolved
Hide resolved
stefbehl
reviewed
Sep 9, 2019
...-repository-api/src/main/java/org/eclipse/hawkbit/repository/model/TargetWithActionType.java
Show resolved
Hide resolved
stefbehl
reviewed
Sep 10, 2019
stefbehl
reviewed
Sep 10, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
stefbehl
reviewed
Sep 10, 2019
stefbehl
reviewed
Sep 10, 2019
...mt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtTargetResourceTest.java
Outdated
Show resolved
Hide resolved
stefbehl
reviewed
Sep 10, 2019
...ce/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtDistributionSetResourceTest.java
Outdated
Show resolved
Hide resolved
stefbehl
suggested changes
Sep 10, 2019
Signed-off-by: Stefan Klotz <[email protected]>
online assignment. fix PR findings. Signed-off-by: Stefan Klotz <[email protected]>
stefbehl
approved these changes
Sep 17, 2019
schabdo
changed the title
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
…awkbit#886) * Add multiassignment to mgmt api target endpoint * Remove single assignment ds to targets offline * Fix tests * Add quota for maxResultingActionsPerManualAssignment * Fix assignment with same target or distribution set multiple times in one request * Log UI error * Add tests * Enable single assignment requests with multiple DSs and types * Remove redundant target to DS assignment methods * Add tests, fix assignment * Fix possible nullpointer during target assignment request * Update api docu * Clean up deployment management code * Enforce MaxActions quota for offline assignment * Fix review findings * Rename property, add migration into * Add builder for DeploymentRequest * Change offline assignment method to accept an assignment list, like online assignment * Fix PR findings Signed-off-by: Stefan Klotz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the /rest/v1/targets/{targetId}/assignedDS POST endpoint to also accept lists of distribution sets.
When 'multi assignments' is enabled it is now possible to assign multiple distribution sets to a single target with one request.