Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency to Vaadin addon tokenfield #875

Merged
merged 14 commits into from
Aug 13, 2019
Merged

Remove dependency to Vaadin addon tokenfield #875

merged 14 commits into from
Aug 13, 2019

Conversation

blomark
Copy link
Contributor

@blomark blomark commented Jul 31, 2019

The Vaadin addon tokenfield wasn't migrated to Vaadin 8. So the addon has to be removed because of the Vaadin 8 migration.

blomark added 9 commits July 12, 2019 16:00
@blomark
Removed vaadin Tokenfield dependency
4c7982d 
Implemented own Tokenfield, but not finished yet. This branch is not
intended to be merged!!!

Signed-off-by: Markus Block <[email protected]>
@blomark
added Combobox and get it running
53cc020 
Signed-off-by: Markus Block <[email protected]>
@blomark
Fixed remaining problems, added Combobox for tag selection
4d2328b 
Signed-off-by: Markus Block <[email protected]>
@blomark
fixed permission check
cbe8a68 
Signed-off-by: Markus Block <[email protected]>
@blomark
fixed tag update
5099bef 
Signed-off-by: Markus Block <[email protected]>
@blomark
Changed Tag assignment in details tab
c83ca06 
Removed assign button and assign a tag when it is selected. In tables
only refreshFilter when necessary.

Signed-off-by: Markus Block <[email protected]>
@blomark
fixed Bulkupload
9b69682 
Signed-off-by: Markus Block <[email protected]>
@blomark
Making Sonar happy
12bd072 
Signed-off-by: Markus Block <[email protected]>
@blomark
Making Sonar happy
f0ed698 
Signed-off-by: Markus Block <[email protected]>
@schabdo schabdo added this to the 0.3.0M6 milestone Jul 31, 2019
@blomark blomark force-pushed the feature_migration_to_vaadin_8_tokenfield branch 2 times, most recently from b0993dd to a2681f3 Compare July 31, 2019 14:06
@blomark
Fixed Sonar issues
d72fc71 
Signed-off-by: Markus Block <[email protected]>
@laverman laverman mentioned this pull request Aug 1, 2019
Closed
bogdan-bondar
bogdan-bondar approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@bogdan-bondar bogdan-bondar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@eclipse-hawkbit eclipse-hawkbit deleted a comment from hawkbit-bot Aug 12, 2019
@eclipse-hawkbit eclipse-hawkbit deleted a comment from hawkbit-bot Aug 12, 2019
@eclipse-hawkbit eclipse-hawkbit deleted a comment from hawkbit-bot Aug 12, 2019
@hawkbit-bot
Copy link

SonarQube analysis reported 26 issues

  • MINOR 26 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR pom.xml#L11: Reorder the elements of this pom to match the recommended order. rule
  2. MINOR AbstractTableDetailsLayout.java#L43: Document the parameter(s): rule
  3. MINOR AbstractTableDetailsLayout.java#L43: Override the "equals" method in this class. rule
  4. MINOR DistributionsView.java#L71: Override the "equals" method in this class. rule
  5. MINOR DistributionSetTableLayout.java#L33: Override the "equals" method in this class. rule
  6. MINOR DistributionTable.java#: Add a new line at the end of this file. rule
  7. MINOR DistributionTable.java#L90: Override the "equals" method in this class. rule
  8. MINOR DistributionTagButtons.java#L50: Override the "equals" method in this class. rule
  9. MINOR DistributionTagButtons.java#L66: Document this public constructor by adding an explicit description. rule
  10. MINOR DistributionTagDropEvent.java#L42: Document this public class by adding an explicit description. rule

@schabdo schabdo merged commit 2b5b8b4 into eclipse-hawkbit:master Aug 13, 2019
@schabdo schabdo deleted the feature_migration_to_vaadin_8_tokenfield branch August 13, 2019 09:19
AmmarBikic pushed a commit to bosch-io/hawkbit that referenced this pull request Oct 2, 2020
@blomark
Remove dependency to Vaadin addon tokenfield (eclipse-hawkbit#875)
143a862 
* Removed vaadin Tokenfield dependency

Implemented own Tokenfield, but not finished yet. This branch is not
intended to be merged!!!

Signed-off-by: Markus Block <[email protected]>

* added Combobox and get it running

Signed-off-by: Markus Block <[email protected]>

* Fixed remaining problems, added Combobox for tag selection

Signed-off-by: Markus Block <[email protected]>

* fixed permission check

Signed-off-by: Markus Block <[email protected]>

* fixed tag update

Signed-off-by: Markus Block <[email protected]>

* Changed Tag assignment in details tab

Removed assign button and assign a tag when it is selected. In tables
only refreshFilter when necessary.

Signed-off-by: Markus Block <[email protected]>

* fixed Bulkupload

Signed-off-by: Markus Block <[email protected]>

* Making Sonar happy

Signed-off-by: Markus Block <[email protected]>

* Making Sonar happy

Signed-off-by: Markus Block <[email protected]>

* Fixed Bug in DistTokenfield and sorted Tags in Tag list

Signed-off-by: Markus Block <[email protected]>

* Making Sonar happy

Signed-off-by: Markus Block <[email protected]>

* Fixed Sonar issues

Signed-off-by: Markus Block <[email protected]>

* Implemented code review remarks

Signed-off-by: Markus Block <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkbit-bot hawkbit-bot hawkbit-bot left review comments

@bogdan-bondar bogdan-bondar bogdan-bondar approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.3.0M6
Development

Successfully merging this pull request may close these issues.
4 participants
@blomark @hawkbit-bot @bogdan-bondar @schabdo