Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return action IDs created by target-distributionset assignment #864

Merged

Conversation

a-sayyed
Copy link
Contributor

@a-sayyed a-sayyed commented Jul 12, 2019

Added the possibility to see assigned actions as a result of a target-distributionSet assignment.
The assigned actions are represented as a collection of action(id + self link) in the payload in MgmtTargetAssignmentResponseBody

Signed-off-by: Ahmed Sayed [email protected]

@a-sayyed a-sayyed marked this pull request as ready for review July 23, 2019 07:17
@a-sayyed a-sayyed force-pushed the feature/retrieve_all_open_actionIds branch from 31d4ed7 to 04b11ec Compare July 23, 2019 07:53
Signed-off-by: Ahmed Sayed <[email protected]>
@a-sayyed a-sayyed force-pushed the feature/retrieve_all_open_actionIds branch from 01eb312 to 22b18ce Compare August 9, 2019 12:22
@hawkbit-bot
Copy link

SonarQube analysis reported 21 issues

  • MINOR 18 minor
  • INFO 3 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR PropertyBasedArtifactUrlHandler.java#L76: Document this public constructor by adding an explicit description. rule
  2. MINOR DdiCancelActionTest.java#L147: Remove this use of "Thread.sleep()". rule
  3. MINOR DdiCancelActionTest.java#L180: Remove this use of "Thread.sleep()". rule
  4. MINOR DosFilterTest.java#L104: Remove this use of "Thread.sleep()". rule
  5. MINOR DosFilterTest.java#L144: Remove this use of "Thread.sleep()". rule
  6. MINOR JpaTargetManagement.java#L124: Document this public constructor by adding an explicit description. rule
  7. MINOR OnlineDsAssignmentStrategy.java#L56: Refactor this code to use the more specialised Functional Interface 'BooleanSupplier' rule
  8. MINOR DistributionSetManagementTest.java#L555: Remove this use of "Thread.sleep()". rule
  9. MINOR TargetManagementTest.java#L591: Remove this use of "Thread.sleep()". rule
  10. MINOR TargetManagementTest.java#L1011: Remove this use of "Thread.sleep()". rule

@StefanKlt
Copy link
Contributor

The response-fields section seems to be missing in the mgmt api target documentation. Please add

==== Response fields 
include::{snippets}/targets/post-assign-distribution-set-to-target/response-fields.adoc[]

to targets-api-guide.adoc under

== POST /rest/v1/targets/{targetId}/assignedDS
(...)
=== Response (Status 200)

Signed-off-by: Ahmed Sayed <[email protected]>
…l_open_actionIds

Signed-off-by: Ahmed Sayed <[email protected]>

# Conflicts:
#	hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
#	hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/OnlineDsAssignmentStrategy.java
#	hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/RepositoryApplicationConfiguration.java
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
@schabdo schabdo merged commit d40b11d into eclipse-hawkbit:master Aug 20, 2019
@schabdo schabdo deleted the feature/retrieve_all_open_actionIds branch August 20, 2019 09:31
@schabdo schabdo changed the title introduced open actionIds in MgmtTargetAssignmentResponseBody Return action IDs created by target-distributionset assignment Jan 16, 2020
AmmarBikic pushed a commit to bosch-io/hawkbit that referenced this pull request Oct 2, 2020
…e-hawkbit#864)

* introduced open actionIds in MgmtTargetAssignmentResponseBody

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed SonarQube issues

Signed-off-by: Ahmed Sayed <[email protected]>

* removed unused method parameter

Signed-off-by: Ahmed Sayed <[email protected]>

* updated documentation tests

Signed-off-by: Ahmed Sayed <[email protected]>

* added limit to the alreadyAssignedActions in the AssignmentResult

Signed-off-by: Ahmed Sayed <[email protected]>

* moved alreadyAssignedActions limitation to MgmtDistributionSetMapper

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed review findings

Signed-off-by: Ahmed Sayed <[email protected]>

* removed alreadyAssignedActions

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed sonarQube issues

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed compilation error

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed PR review findings

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed PR review findings

Signed-off-by: Ahmed Sayed <[email protected]>

* Renamed AssignmentResult to AbstractAssignmentResult

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed review findings

Signed-off-by: Ahmed Sayed <[email protected]>

* fixed formatting

Signed-off-by: Ahmed Sayed <[email protected]>

* reverted method visibility

Signed-off-by: Ahmed Sayed <[email protected]>
eclipsewebmaster pushed a commit to eclipse-hawkbit/hawkbit-website that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants