-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return action IDs created by target-distributionset assignment #864
Merged
schabdo
merged 19 commits into
eclipse-hawkbit:master
from
bosch-io:feature/retrieve_all_open_actionIds
Aug 20, 2019
Merged
Return action IDs created by target-distributionset assignment #864
schabdo
merged 19 commits into
eclipse-hawkbit:master
from
bosch-io:feature/retrieve_all_open_actionIds
Aug 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sayyed
commented
Jul 12, 2019
...kbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/model/AssignmentResult.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...f-amqp/src/test/java/org/eclipse/hawkbit/integration/AbstractAmqpServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...-api/src/main/java/org/eclipse/hawkbit/repository/model/DistributionSetAssignmentResult.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...itory-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDistributionSetManagement.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...ository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/TargetManagementSearchTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...ository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/TargetManagementSearchTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...source/src/main/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtDistributionSetResource.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 12, 2019
...t-mgmt-resource/src/main/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtTargetResource.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 17, 2019
...bit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaTargetManagement.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 17, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 17, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 17, 2019
...c/test/java/org/eclipse/hawkbit/rest/mgmt/documentation/TargetResourceDocumentationTest.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 18, 2019
...-api/src/main/java/org/eclipse/hawkbit/repository/model/DistributionSetAssignmentResult.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
31d4ed7
to
04b11ec
Compare
a-sayyed
commented
Jul 24, 2019
...awkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/ActionRepository.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Jul 24, 2019
...rg/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtTargetAssignmentResponseBodyTest.java
Show resolved
Hide resolved
a-sayyed
commented
Jul 24, 2019
...rg/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtTargetAssignmentResponseBodyTest.java
Show resolved
Hide resolved
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
...mgmt-api/src/main/java/org/eclipse/hawkbit/mgmt/json/model/distributionset/MgmtActionId.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Sayed <[email protected]>
StefanKlt
reviewed
Aug 9, 2019
...-api/src/main/java/org/eclipse/hawkbit/repository/model/DistributionSetAssignmentResult.java
Outdated
Show resolved
Hide resolved
a-sayyed
commented
Aug 9, 2019
...epository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/DeploymentManagementTest.java
Outdated
Show resolved
Hide resolved
…l_open_actionIds Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
01eb312
to
22b18ce
Compare
hawkbit-bot
reviewed
Aug 9, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Aug 9, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Aug 9, 2019
...kbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/model/AssignmentResult.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Aug 9, 2019
...mt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtTargetResourceTest.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Aug 9, 2019
...mt-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtTargetResourceTest.java
Show resolved
Hide resolved
SonarQube analysis reported 21 issues Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
Signed-off-by: Ahmed Sayed <[email protected]>
StefanKlt
reviewed
Aug 12, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
StefanKlt
reviewed
Aug 12, 2019
...repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java
Outdated
Show resolved
Hide resolved
StefanKlt
reviewed
Aug 12, 2019
...ory-test/src/main/java/org/eclipse/hawkbit/repository/test/util/AbstractIntegrationTest.java
Outdated
Show resolved
Hide resolved
The response-fields section seems to be missing in the mgmt api target documentation. Please add
to targets-api-guide.adoc under
|
Signed-off-by: Ahmed Sayed <[email protected]>
…l_open_actionIds Signed-off-by: Ahmed Sayed <[email protected]> # Conflicts: # hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaDeploymentManagement.java # hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/OnlineDsAssignmentStrategy.java # hawkbit-repository/hawkbit-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/RepositoryApplicationConfiguration.java
Signed-off-by: Ahmed Sayed <[email protected]>
Signed-off-by: Ahmed Sayed <[email protected]>
StefanKlt
approved these changes
Aug 16, 2019
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
…e-hawkbit#864) * introduced open actionIds in MgmtTargetAssignmentResponseBody Signed-off-by: Ahmed Sayed <[email protected]> * fixed SonarQube issues Signed-off-by: Ahmed Sayed <[email protected]> * removed unused method parameter Signed-off-by: Ahmed Sayed <[email protected]> * updated documentation tests Signed-off-by: Ahmed Sayed <[email protected]> * added limit to the alreadyAssignedActions in the AssignmentResult Signed-off-by: Ahmed Sayed <[email protected]> * moved alreadyAssignedActions limitation to MgmtDistributionSetMapper Signed-off-by: Ahmed Sayed <[email protected]> * fixed review findings Signed-off-by: Ahmed Sayed <[email protected]> * removed alreadyAssignedActions Signed-off-by: Ahmed Sayed <[email protected]> * fixed sonarQube issues Signed-off-by: Ahmed Sayed <[email protected]> * fixed compilation error Signed-off-by: Ahmed Sayed <[email protected]> * fixed PR review findings Signed-off-by: Ahmed Sayed <[email protected]> * fixed PR review findings Signed-off-by: Ahmed Sayed <[email protected]> * Renamed AssignmentResult to AbstractAssignmentResult Signed-off-by: Ahmed Sayed <[email protected]> * fixed review findings Signed-off-by: Ahmed Sayed <[email protected]> * fixed formatting Signed-off-by: Ahmed Sayed <[email protected]> * reverted method visibility Signed-off-by: Ahmed Sayed <[email protected]>
eclipsewebmaster
pushed a commit
to eclipse-hawkbit/hawkbit-website
that referenced
this pull request
Dec 15, 2022
See eclipse-hawkbit/hawkbit#864 Signed-off-by: Dominic Schabel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to see assigned actions as a result of a target-distributionSet assignment.
The assigned actions are represented as a collection of action(id + self link) in the payload in
MgmtTargetAssignmentResponseBody
Signed-off-by: Ahmed Sayed [email protected]