Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB and RabbitMQ integration tests and PostgreSQL testing/bug fixing #1047

Merged
merged 18 commits into from
Jan 14, 2021

Conversation

kaizimmerm
Copy link
Contributor

Hi,

because of #1045 I worked a bit on an integration test matrix. Leveraging Azure Pipelines up to 10 jobs in parallel capability it can be done in reasonable time. See https://dev.azure.com/kaizimmerm/eclipse/_build/results?buildId=66&view=results I also created a .devcontainer config (I cannot live without these nowadays :))

While at it I also added integration tests for the PostgreSQL support. However, the tests showed quite a lot of issues that needed fixing.

What is left is a general different behavior in RSQL queries as PostgreSQL is handling numbers not like strings. That is ok imho but I had to make some of the tests aware of that behavior.

I reverted also the Eclipselink version bump from @schabdo as this would fix #1045 for the time being. Any thoughts on that one?

Kai

Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
@kaizimmerm kaizimmerm requested a review from schabdo November 16, 2020 20:35
@kaizimmerm kaizimmerm marked this pull request as draft November 17, 2020 06:15
@kaizimmerm kaizimmerm force-pushed the db-test-matrix branch 12 times, most recently from ee36a74 to c3cb284 Compare November 17, 2020 07:02
@kaizimmerm kaizimmerm force-pushed the db-test-matrix branch 5 times, most recently from 49b05f2 to 8c209d0 Compare November 17, 2020 12:19
@kaizimmerm kaizimmerm marked this pull request as ready for review November 17, 2020 19:09
@kaizimmerm kaizimmerm force-pushed the db-test-matrix branch 4 times, most recently from 65750e2 to ebd64ad Compare November 18, 2020 07:02
@schabdo schabdo added this to the 0.3.0M7 milestone Jan 14, 2021
@schabdo
Copy link
Contributor

schabdo commented Jan 14, 2021

LGTM, thanks for spending the effort on this! Regarding the EclipseLink version I commented here.
Looking forward to see another contribution integrating the pipeline in hawkBit as well :)

@schabdo schabdo added the CQ label Jan 14, 2021
@schabdo schabdo merged commit e9f11d2 into eclipse-hawkbit:master Jan 14, 2021
@schabdo schabdo removed the CQ label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JPA Repository broken with SQLServer after Eclipselink update
2 participants