-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB and RabbitMQ integration tests and PostgreSQL testing/bug fixing #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b-test-matrix Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
Signed-off-by: Kai Zimmermann <[email protected]>
ee36a74
to
c3cb284
Compare
49b05f2
to
8c209d0
Compare
8c209d0
to
9e8a923
Compare
65750e2
to
ebd64ad
Compare
ebd64ad
to
bd83d2d
Compare
LGTM, thanks for spending the effort on this! Regarding the EclipseLink version I commented here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
because of #1045 I worked a bit on an integration test matrix. Leveraging Azure Pipelines up to 10 jobs in parallel capability it can be done in reasonable time. See https://dev.azure.com/kaizimmerm/eclipse/_build/results?buildId=66&view=results I also created a .devcontainer config (I cannot live without these nowadays :))
While at it I also added integration tests for the PostgreSQL support. However, the tests showed quite a lot of issues that needed fixing.
What is left is a general different behavior in RSQL queries as PostgreSQL is handling numbers not like strings. That is ok imho but I had to make some of the tests aware of that behavior.
I reverted also the Eclipselink version bump from @schabdo as this would fix #1045 for the time being. Any thoughts on that one?
Kai