Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup force delete action documentation #1042

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

stschake
Copy link
Contributor

@stschake stschake commented Nov 6, 2020

This was doing a GET request and didn't even specify
the action ID.

Signed-off-by: Stefan Schake [email protected]

@stschake stschake force-pushed the feature/fix-target-docs branch from 3ac885f to f93fe07 Compare November 6, 2020 12:25
@hawkbit-bot
Copy link

Can one of the admins verify this patch?

@stschake stschake force-pushed the feature/fix-target-docs branch from f93fe07 to ca74eb2 Compare November 6, 2020 12:50
@stschake stschake marked this pull request as draft November 12, 2020 10:17
@schabdo
Copy link
Contributor

schabdo commented Dec 22, 2020

Well spotted @stschake! Seems like test is only failing because the action is not in state canceled hence it's not allowed to force quite the action

This was doing a GET request and didn't even specify
the action ID.

Signed-off-by: Stefan Schake <[email protected]>
@stschake stschake force-pushed the feature/fix-target-docs branch from ca74eb2 to 645145f Compare January 11, 2021 12:46
@stschake
Copy link
Contributor Author

Finally got a minute to update this, should be good now.

@schabdo
Copy link
Contributor

schabdo commented Jan 14, 2021

Is there anything else missing? If not I'll have a closer look. Just asking due to the draft state of PR

@stschake stschake marked this pull request as ready for review January 14, 2021 08:38
@stschake
Copy link
Contributor Author

Marked it as ready now, thanks for checking!

@schabdo schabdo added this to the 0.3.0M7 milestone Jan 14, 2021
@schabdo schabdo merged commit 70ee947 into eclipse-hawkbit:master Jan 14, 2021
@schabdo
Copy link
Contributor

schabdo commented Jan 14, 2021

Sure, here we go ...

diegorondini pushed a commit to Kynetics/hawkbit that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants