Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister UI remote event push strategy from application context #1022

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

bogdan-bondar
Copy link
Contributor

Signed-off-by: Bogdan Bondar [email protected]

@schabdo schabdo added the bug label Oct 6, 2020
@schabdo schabdo added this to the 0.3.0M7 milestone Oct 6, 2020
}

private void clearContextListener() {
if (pushStrategy instanceof ApplicationListener && context instanceof AbstractApplicationContext) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear context from SpringContextHelper

Copy link
Contributor

@aktivk aktivk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@stefbehl stefbehl merged commit a092747 into eclipse-hawkbit:master Oct 12, 2020
@stefbehl stefbehl deleted the fix_ui_push_registration branch October 12, 2020 09:42
krishna-devolo pushed a commit to devolo/hawkbit that referenced this pull request Sep 23, 2021
…lipse-hawkbit#1022)

* deregister UI remote event push strategy from application context
* remove application context from holder after detaching the UI

Signed-off-by: Bogdan Bondar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants