Make the debounce time of publish diagnostic job adaptive #2443
+37
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the debounce time of publish diagnostic jobs are adaptive. Ranging from [400, 2000] ms.
Signed-off-by: Sheng Chen sheche@microsoft.com
How to test the impact of this change:
java.trace.server
tomessages
, which will let the client print all the response time in the output channel.PetControllerTests
.void testProcessUpdateFormHasErrors26()
, do some modification to trigger different kinds of LSP requests. When I test it locally, I typedSystem.out.println();
and then useBackspace
to remove the typed characters one by one./\[Trace.*\] Received response \'.*\' in (\d+)ms/
can help us pick the time out.Test Result
By doing the above experiment according to the above steps with and without PR, the average time cost to process a request list below:
Looks like the change works well from the customer's feedback: redhat-developer/vscode-java#1765 (comment)