Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger signature help on completion item selected #2065

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Apr 21, 2022

more informations: redhat-developer/vscode-java#2426

Signed-off-by: sheche sheche@microsoft.com

Signed-off-by: sheche <sheche@microsoft.com>
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this works well for me and we should adopt it. Just some small comments on the naming.

Signed-off-by: sheche <sheche@microsoft.com>
@rgrunber rgrunber self-requested a review April 25, 2022 14:44
@jdneo jdneo merged commit d1ceece into eclipse-jdtls:master Apr 26, 2022
@jdneo jdneo deleted the cs/enable-signature-help branch April 26, 2022 00:50
@rgrunber rgrunber added this to the Early May 2022 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants