Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the performance of inferSelection #1609

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

CsCherrYY
Copy link
Contributor

When the language server is just finding valid expression, ExtractMethodRefactoring.checkInitialConditions() has no need to do some initialize methods, in some corner cases such as working on a large Java file with many duplicate methods, this may affect the performance of inferSelection.

This PR is to remove the unnecessary processes.

Signed-off-by: Shi Chen chenshi@microsoft.com

Signed-off-by: Shi Chen <chenshi@microsoft.com>
@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@testforstephen
Copy link
Contributor

add to whitelist

@testforstephen
Copy link
Contributor

I replied "add to whitelist" and it doesn't seem to work.
@rgrunber @fbricon Do it need any special permissions for this?

@testforstephen
Copy link
Contributor

ping... @rgrunber @snjeza @fbricon

@testforstephen
Copy link
Contributor

test this please

@testforstephen testforstephen added this to the End November 2020 milestone Nov 27, 2020
@testforstephen testforstephen merged commit b6c7d48 into eclipse-jdtls:master Nov 27, 2020
@CsCherrYY CsCherrYY deleted the inferSelectionTest branch November 30, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants