Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean up for using try-with-resource #2344

Closed
rgrunber opened this issue Nov 23, 2022 · 1 comment · Fixed by #2410
Closed

Add clean up for using try-with-resource #2344

rgrunber opened this issue Nov 23, 2022 · 1 comment · Fixed by #2410
Assignees

Comments

@rgrunber
Copy link
Contributor

See https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/9d4e8ecc47ba06fa06eaa9c2f6c535503ac4d6df/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/TryWithResourceCleanUp.java . This will need to be migrated from jdt.ui to jdt.core.manipulation. Once migrated, adding it to cleanups should be straightforward.

See eclipse-jdt/eclipse.jdt.ui#288 & eclipse-jdt/eclipse.jdt.ui#294 as a guide on how to do this in a fairly easy way.

@rgrunber rgrunber moved this to 📋 Backlog in IDE Cloudaptors Dec 14, 2022
@rgrunber rgrunber moved this from 📋 Sprint Backlog to 🏗 In progress in IDE Cloudaptors Jan 10, 2023
@rgrunber rgrunber moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors Jan 10, 2023
@rgrunber
Copy link
Contributor Author

Once eclipse-jdt/eclipse.jdt.ui#375 is merged, this can proceed.

@rgrunber rgrunber added this to the End February 2023 milestone Jan 19, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants