Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make explicit build error if compiler version is below C++17 to avoid cryptic errors on user machines #235

Open
milyin opened this issue Sep 25, 2024 · 0 comments
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Sep 25, 2024

Describe the release item

There is a report that is_value_reference_v not found. This may happen if compiler lower than C++17 is used. We need to explicitly check this:

typename std::conditional_t<std::is_lvalue_reference_v<D>, D, std::remove_reference_t<D>> _drop;
                                      ^~~~~~~~~~~~~~~~~~~~~
                                      is_lvalue_reference
/usr/local/include/zenoh/detail/closures.hxx:48:38: error: ‘is_lvalue_reference_v’ is not a member of ‘std’
/usr/local/include/zenoh/detail/closures.hxx:48:38: note: suggested alternative: ‘is_lvalue_reference’
@milyin milyin added the release Part of the next release label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: No status
Development

No branches or pull requests

1 participant