Reduce useless HTTP 2 status's String allocation

franz1981 · vietj · commit f2d18ceae66f · 2024-01-15T10:07:12.000+01:00
diff --git a/src/main/java/io/vertx/core/http/impl/Http2ServerResponse.java b/src/main/java/io/vertx/core/http/impl/Http2ServerResponse.java
@@ -515,7 +515,7 @@ private boolean checkSendHeaders(boolean end, boolean checkFlush) {
   }
 
   private void prepareHeaders() {
-    headers.status(Integer.toString(status.code())); // Could be optimized for usual case ?
+    headers.status(status.codeAsText()); // Could be optimized for usual case ?
     if (contentEncoding != null && headers.get(HttpHeaderNames.CONTENT_ENCODING) == null) {
       headers.set(HttpHeaderNames.CONTENT_ENCODING, contentEncoding);
     }

Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@ private boolean checkSendHeaders(boolean end, boolean checkFlush) {`
`515`	`515`	`}`
`516`	`516`
`517`	`517`	`private void prepareHeaders() {`
`518`		`- headers.status(Integer.toString(status.code())); // Could be optimized for usual case ?`
	`518`	`+ headers.status(status.codeAsText()); // Could be optimized for usual case ?`
`519`	`519`	`if (contentEncoding != null && headers.get(HttpHeaderNames.CONTENT_ENCODING) == null) {`
`520`	`520`	`headers.set(HttpHeaderNames.CONTENT_ENCODING, contentEncoding);`
`521`	`521`	`}`