fix(cronjob expiry): added the missing environment value for portal

[dhiren-singh-007]

Description

Added environment value for PortalSettings in charts/ssi-credential-issuer/templates/cronjob-expiry-app.yaml
fixes #195
closes #195

Why

To run this project PortalSettings are required

Issue

Issue #195

Checklist

Please delete options that are not relevant.

• I have followed the contributing guidelines
• I have performed a self-review of my own code
• I have successfully tested my changes locally

[evegufy]

Hi @dhiren-singh-007 thank you for the fix! Just letting you know that the review will take a couple of days as @Phil91 is on vacation this week and I'd like him to review as well.

I assume the config should also be added to the appsettings as we want maintain all config there as well, but let's wait for @Phil91 feedback

[dhiren-singh-007]

@evegufy No problem . Thanks for the update .
Agree appsettings should be updated , I will wait for @Phil91 feedback.

[Phil91]

hey @dhiren-singh-007 thanks for the adjustment. the changes look good to me. Could you please update the appsettings.json in the SsiCredentialIssuer.Expiry.App project to include the Portal section as well similar to

ssi-credential-issuer/src/processes/Processes.Worker/appsettings.json

Line 30 in e845488

"Portal": {

[evegufy]

Unfortunately you merged the wrong branch (main instead of the release branch): could you please rebase to release branch so that only you commits are shown in the diff?

[dhiren-singh-007]

Unfortunately you merged the wrong branch (main instead of the release branch): could you please rebase to release branch so that only you commits are shown in the diff?

Thanks @evegufy , Yeah this happens after syncing the Fork from Github UI . It looks like I should use commands to rebase .

[dhiren-singh-007]

oh i got it now , So in forked repo Github UI shows a update branch option . So i thought it just sync the changes of the branch which exist only on upstream but it actually merged the main from upstream . Let me try to fix it else i will create a new PR