Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Translations Needs to be Harmonised with Constants #1163

Open
Usmanfee opened this issue Sep 27, 2024 · 0 comments
Open

Notification Translations Needs to be Harmonised with Constants #1163

Usmanfee opened this issue Sep 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Usmanfee
Copy link

Usmanfee commented Sep 27, 2024

Current Behavior

Currently, we have a naming convention conflict between the keys mentioned in the Notification Translation and the keys in the constants file. In the code, we are mapping constant keys to translations to retrieve the relevant translation. However, due to mismatched word casing, it results in the translation key being returned instead of the value.

Screenshot 2024-09-27 at 08 57 04 Screenshot 2024-09-27 at 08 58 51 Screenshot 2024-09-27 at 09 00 59

Screenshot 2024-09-27 at 09 57 20

Expected Behavior

The keys format(either camelcase, or any other) used in Notification translation file should be consistent with the key's value in CONSTANT.ts.

Steps To Reproduce

  • Navigate to Profile Menu to top right.
  • Select Notification option from menu.
  • Open notification card and observe the link of the text.
@Usmanfee Usmanfee added the bug Something isn't working label Sep 27, 2024
@Usmanfee Usmanfee changed the title Notification Translations Needs to be Harmonized with Constants Notification Translations Needs to be Harmonised with Constants Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: BACKLOG
Development

No branches or pull requests

1 participant