Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid accidentally assigning view|update_wallets role due to human error #165

Open
pablosec opened this issue Nov 22, 2023 · 1 comment
Open

Comments

@pablosec
Copy link
Contributor

Finding from security assessment 23.12 (2023-11-21)

  • Likelihood for human error in accidentally assigning a role with much higher rights (view_wallets, update_wallets) is high, when the roles are only differentiated by a single letter s.
  • Some measure to avoid accidentally assigning the *_wallets to a user should be implemented, e.g., by renaming either the _wallet variant or the _wallets variant. Other counter-measure
@borisrizov-zf
Copy link
Contributor

@pablosec This issue is somewhat misplaced, as we don't control the assignment of roles. This should be coordinated with portal first. We can accommodate such a change after it has been deployed to portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants