File > Upload Files... should always be enabled + always upload into workspace root

[jankeromnes]

Description

I was recently confused to find the File > Upload Files... menu entry disabled (greyed out).

Only after messing around for a while did I notice that I had to select a directory in the File Tree panel for the feature to be enabled. In my mind, the File menu should not be influenced by the state of the File Tree panel.

For example, in Cloud9, File > Upload Files... was always enabled, and it always uploaded to the workspace root, regardless of which files or directory was currently selected in the File Tree -- only the File Tree context menu was able to upload into different locations.

Reproduction Steps

1. Open any project in Theia
2. Click on File
3. Try to click on Upload Files..., be confused because it's disabled and you're not sure why

OS and Theia version: Mac OS, Firefox Nightly, latest Theia

Diagnostics: (none)

[qx220]

I made a working demo:

qx220@81e69f2

It handles file upload menu item with the following strategy:

• if current selection is undefined, then upload to workspace root folder
• if current selection is a regular file, then upload to its containing folder

[akosyakov]

@qx-juilliard please propose a PR if you want a review, you can make it a draft (or WIP) if you want to check the design first

[qx220]

will do!

[federicobozzini]

Was this issue fixed by this commit #11756 ?

[vince-fugnitto]

Was this issue fixed by this commit #11756 ?

@federicobozzini it doesn't look like there is a default case where it'll upload to the workspace root, a selection is still needed in order for the command to be enabled, while #11756 only handles visibility.