Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markers] No marker icon in the gutter next to the marker's line #1720

Closed
BoykoAlex opened this issue Apr 17, 2018 · 5 comments
Closed

[Markers] No marker icon in the gutter next to the marker's line #1720

BoykoAlex opened this issue Apr 17, 2018 · 5 comments
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers

Comments

@BoykoAlex
Copy link
Contributor

Eclipse, VSCode, Atom all show markers in the view (that's there), squiggly lines in the editor highlighting the range and a marker icon in the gutter.

@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves editor issues related to the editor markers issues related to problem markers labels Apr 18, 2018
@svenefftinge
Copy link
Contributor

Theia does show squiggly lines and icons for diagnostics.
Could you be more precise what is missing?
What did you do and what was the expectation?

@BoykoAlex
Copy link
Contributor Author

BoykoAlex commented Apr 19, 2018

I saw the squiggly line :-) Which package adds squiggly lines? "theia/markers"?
However, the error icon in the gutters i didn't see. Was expecting to see the error icon in the left gutters around line numbers next to the line where squiggly line is shown, but the icon wasn't there...
Is there a separate package adding error icons to the gutters?

@BoykoAlex BoykoAlex changed the title [Markers] No markers in the editor, i.e. squiggly lines and gutter icon [Markers] No marker icon in the gutter next to the marker's line Apr 19, 2018
@AlexTugarev
Copy link
Contributor

@BoykoAlex the error markers are located at the scrollbar.

screen shot 2018-04-19 at 17 01 59

We can also check, if it makes sense (if it actually works) to enable lightbulbs with monaco 0.12.0, ref PR #1681.

@svenefftinge
Copy link
Contributor

Please reopen if we missed something.

@BoykoAlex
Copy link
Contributor Author

The error marker icon (not just colour) shows up in the left gutter around line numbers, but thinks it's far from being something absolutely necessary :-) Squiggly lines are working for me and markers in the scrollbar help too. Thanks very much!-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers
Projects
None yet
Development

No branches or pull requests

4 participants