Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ESM versions of Monaco #1542

Closed
ishitatsuyuki opened this issue Mar 19, 2018 · 6 comments
Closed

Use ESM versions of Monaco #1542

ishitatsuyuki opened this issue Mar 19, 2018 · 6 comments
Labels
monaco issues related to monaco

Comments

@ishitatsuyuki
Copy link
Contributor

microsoft/monaco-editor#18 has been resolved; we may benefit from ESM by bundling them into one bundle, instead of doing XHR for various code files.

@akosyakov
Copy link
Member

akosyakov commented Mar 19, 2018

It depends on #1539.

@akosyakov akosyakov added the monaco issues related to monaco label Mar 19, 2018
@AlexTugarev
Copy link
Contributor

let's await the solution for microsoft/monaco-editor#850

@JonasHelming
Copy link
Contributor

@tsmaeder : Is this even relevant anymore?

@tsmaeder
Copy link
Contributor

@JonasHelming t.b.h, I have no idea.

@colin-grant-work
Copy link
Contributor

@JonasHelming, @tsmaeder, I believe what's referred to here is the ability to bundle Monaco using Webpack rather than our current monaco-loader which uses VSCode's loader which (I think) loads the modules asynchronously by making separate requests for each file it discovers that it needs.

This issue is still relevant, and we may want to think about having some sort of epic about improving our Monaco consumption / simplifying Monaco uplifts:

  • Updating the documentation (minimum)
  • Consuming Monaco via Webpack
  • Automating the generation of this file or (much better) eliminating that file in favor of typings coming from the Monaco package.

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Nov 4, 2022

I believe that with the last few Monaco uplifts, we've done all the things that I described above, so I think this ticket is ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco
Projects
None yet
Development

No branches or pull requests

6 participants