Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate preview support for markdown files #13895

Open
msujew opened this issue Jul 8, 2024 · 2 comments
Open

Deprecate preview support for markdown files #13895

msujew opened this issue Jul 8, 2024 · 2 comments
Labels
markdown issues related to markdown preview issues related to the preview proposal feature proposals (potential future features)

Comments

@msujew
Copy link
Member

msujew commented Jul 8, 2024

Since we're now deprecating the Git extension (#12745) in favor of using VS Code's builtins, I'm wondering whether it makes sense to remove the markdown preview feature from the @theia/preview package. IMO it's a worse version of the vscode.markdown builtin extension and bloats the bundle due to the inclusion of highlight.js (and its 1.3mb minified bundle size).

@msujew msujew added preview issues related to the preview markdown issues related to markdown proposal feature proposals (potential future features) labels Jul 8, 2024
@msujew
Copy link
Member Author

msujew commented Jul 16, 2024

This has been discussed in last weeks dev call. We will likely deprecate/remove the feature after sending out an info about this via the Theia mailing list.

I aim to remove the related code for the August (1.53) release.

@msujew msujew mentioned this issue Aug 3, 2024
@msujew
Copy link
Member Author

msujew commented Dec 9, 2024

@zhouxinghong I appreciate the feedback. While I cannot entirely agree that the markdown preview by VS Code is really broken or outdated (and least not more broken or outdated than our own, 6 year old implementation), I can see the benefit of us delivering our own markdown preview feature.

However, we're dealing with a lot of code to maintain in our codebase already (250.000+ LoC), so every additional feature actually puts a lot of maintenance burden on our end. In fact, I don't think we did a good job of maintaining the feature at all. If we can offload this effort to the VS Code team (a much larger team than ours), we try to do that so we can focus on the more important features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markdown issues related to markdown preview issues related to the preview proposal feature proposals (potential future features)
Projects
None yet
Development

No branches or pull requests

1 participant