Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI locks up on running rust-analyzer #13835

Closed
Tracked by #13192
hsnoil opened this issue Jun 20, 2024 · 2 comments · Fixed by #13841
Closed
Tracked by #13192

UI locks up on running rust-analyzer #13835

hsnoil opened this issue Jun 20, 2024 · 2 comments · Fixed by #13841
Labels
bug bugs found in the application problems issues related to the problems widget
Milestone

Comments

@hsnoil
Copy link

hsnoil commented Jun 20, 2024

Bug Description:

When using rust-analyzer(with proper binary) on the appimage, I ran into UI locking up issues on certain code after saving the first time.

I have no issues running this in vscode, but in theia it locks up the HTML UI.

The native UI still works but does not accept commands and I have to kill the theia process

Steps to Reproduce:

  1. Use Theia appimage
  2. Install rust-analyzer plugin (insure you are using proper binary)
  3. Extract the minimum example code: test1.zip
  4. Go to main.rs and then save, once first save is done. Type let and Theia will freeze up before finishing typing with the suggestions menu open

Additional Information

  • Operating System: Linux
  • Theia Version: 1.50.100
@JonasHelming JonasHelming mentioned this issue Jun 21, 2024
63 tasks
@msujew
Copy link
Member

msujew commented Jun 24, 2024

Took a quick look at this. It seems like our problem tree widget runs into an infinite loop here:

for (const node of new TopDownTreeIterator(root, {
pruneCollapsed: true,
pruneSiblings: true
})) {

Which then eventually yields a out of memory error. Taking a look at the tree model shows a cyclic reference between tree nodes (which makes them non-tree nodes from a graph perspective). I'll take a further look at this later and see what the root cause is. It's likely based on how we update/modify the problem tree model.

@msujew
Copy link
Member

msujew commented Jun 24, 2024

See #13841 for a fix.

@msujew msujew added bug bugs found in the application problems issues related to the problems widget labels Jun 24, 2024
@jfaltermeier jfaltermeier added this to the 1.51.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application problems issues related to the problems widget
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants